Skip to content

Marco montero/review low variance sampling - #561

Open
marco-montero wants to merge 9 commits into
Ekumen-OS:mainfrom
marco-montero:marco-montero/review-low-variance-sampling
Open

Marco montero/review low variance sampling#561
marco-montero wants to merge 9 commits into
Ekumen-OS:mainfrom
marco-montero:marco-montero/review-low-variance-sampling

Conversation

@marco-montero

Copy link
Copy Markdown

Proposed changes

This PR adds the strategy of low-variance sampling for the resampling step. Adds a new range adaptor called beluga::views::low_variance_sample. Related to: #48

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

How to run it?

colcon build --packages-up-to beluga && ./build/beluga/test/beluga/test_beluga --gtest_filter="LowVarianceSampleView"

larodriguez22 and others added 9 commits September 1, 2025 18:13
Signed-off-by: ADEGA <la.rodriguez@uniandes.edu.co>
… sample

Signed-off-by: ADEGA <la.rodriguez@uniandes.edu.co>
Signed-off-by: ADEGA <la.rodriguez@uniandes.edu.co>
Signed-off-by: ADEGA <la.rodriguez@uniandes.edu.co>
Signed-off-by: ADEGA <la.rodriguez@uniandes.edu.co>
Signed-off-by: ADEGA <la.rodriguez@uniandes.edu.co>
@marco-montero
marco-montero requested a review from hidmic April 21, 2026 18:28

@hidmic hidmic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @marco-montero (and @larodriguez22), with green CI of course.

How does this fare in micro benchmarks?

@hidmic

hidmic commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Also, mind to update the PR title to be more descriptive?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants