Marco montero/review low variance sampling - #561
Open
marco-montero wants to merge 9 commits into
Open
Conversation
Signed-off-by: ADEGA <la.rodriguez@uniandes.edu.co>
… sample Signed-off-by: ADEGA <la.rodriguez@uniandes.edu.co>
Signed-off-by: ADEGA <la.rodriguez@uniandes.edu.co>
Signed-off-by: ADEGA <la.rodriguez@uniandes.edu.co>
Signed-off-by: ADEGA <la.rodriguez@uniandes.edu.co>
Signed-off-by: ADEGA <la.rodriguez@uniandes.edu.co>
hidmic
approved these changes
May 26, 2026
Collaborator
There was a problem hiding this comment.
This looks great @marco-montero (and @larodriguez22), with green CI of course.
How does this fare in micro benchmarks?
Collaborator
|
Also, mind to update the PR title to be more descriptive? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds the strategy of low-variance sampling for the resampling step. Adds a new range adaptor called beluga::views::low_variance_sample. Related to: #48
Type of change
💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.
Checklist
Put an
xin the boxes that apply. This is simply a reminder of what we will require before merging your code.Additional comments
How to run it?
colcon build --packages-up-to beluga && ./build/beluga/test/beluga/test_beluga --gtest_filter="LowVarianceSampleView"