Skip to content

Patch support for Eigen5 - #578

Open
Timple wants to merge 3 commits into
Ekumen-OS:mainfrom
nobleo:eigen5
Open

Patch support for Eigen5#578
Timple wants to merge 3 commits into
Ekumen-OS:mainfrom
nobleo:eigen5

Conversation

@Timple

@Timple Timple commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

This is a (rather not-so-nice looking) fix to support Eigen5.

The issue is not yours, but this patch will add support until strasdat/Sophus#558 is fixed upstream.

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Type of change

  • 🐛 Bugfix (change which fixes an issue)
  • 🚀 Feature (change which adds functionality)
  • 📚 Documentation (change which fixes or extends documentation)

💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.

Checklist

Put an x in the boxes that apply. This is simply a reminder of what we will require before merging your code.

  • Lint and unit tests (if any) pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All commits have been signed for DCO

Additional comments

Anything worth mentioning to the reviewers.

@glpuga
glpuga self-requested a review August 18, 2026 11:06
@glpuga

glpuga commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Thanks, we'll take a look!

@Timple

Timple commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

Thank you! It's finished and validated now.

Didn't validate against packages depending on this one, so that got me two regressions which I solved now.

Timple added 3 commits August 18, 2026 13:24
Until strasdat/Sophus#558

Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants