epacket: interfaces: bt_adv: release net_buf ASAP
#257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release the epacket `net_buf` as soon as possible after completion, instead of deferring this to the same time that advertising is potentially chained. Because the chaining can happen on the same workq that is also trying to allocate buffers, this could lead to deadlocks. Signed-off-by: Jordan Yates <[email protected]>
Treat all `zsock_socket` return codes less than 0 as errors. Signed-off-by: Jordan Yates <[email protected]>
When `zsock_getaddrinfo` fails, output `errno` to help debugging. Signed-off-by: Jordan Yates <[email protected]>
Increase version to `v0.3.1` to fix Bluetooth deadlock and improve debugging output. Signed-off-by: Jordan Yates <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 104 104
Lines 3961 3961
Branches 622 622
=======================================
Hits 3652 3652
Misses 156 156
Partials 153 153 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release the epacket
net_bufas soon as possible after completion,instead of deferring this to the same time that advertising is
potentially chained. Because the chaining can happen on the same workq
that is also trying to allocate buffers, this could lead to deadlocks.