Skip to content

fix(portfolio): further toTokenActivity breaking #3881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Conversation

jorbuedo
Copy link
Contributor

Description / Change(s) / Related issue(s)

Ticket

https://emurgo.atlassian.net/browse/YV-306

@jorbuedo jorbuedo added the fix label Mar 24, 2025
@jorbuedo jorbuedo requested a review from stackchain March 24, 2025 13:29
@jorbuedo jorbuedo self-assigned this Mar 24, 2025
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.73%. Comparing base (81c61dc) to head (eea7233).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3881      +/-   ##
===========================================
- Coverage    22.74%   22.73%   -0.01%     
===========================================
  Files         1174     1174              
  Lines        22321    22320       -1     
  Branches      3452     3453       +1     
===========================================
- Hits          5076     5075       -1     
  Misses       17100    17100              
  Partials       145      145              
Components Coverage Δ
@yoroi/api 100.00% <ø> (ø)
@yoroi/blockchains 100.00% <ø> (ø)
@yoroi/claim 100.00% <ø> (ø)
@yoroi/common 100.00% <ø> (ø)
@yoroi/dapp-connector 100.00% <ø> (ø)
@yoroi/exchange 100.00% <ø> (ø)
@yoroi/explorers 100.00% <ø> (ø)
@yoroi/identicon 100.00% <ø> (ø)
@yoroi/links 100.00% <ø> (ø)
@yoroi/notifications 100.00% <ø> (ø)
@yoroi/portfolio 100.00% <100.00%> (ø)
@yoroi/resolver 100.00% <ø> (ø)
@yoroi/setup-wallet 100.00% <ø> (ø)
@yoroi/staking 68.95% <ø> (ø)
@yoroi/swap 100.00% <ø> (ø)
@yoroi/theme 100.00% <ø> (ø)
@yoroi/transfer 100.00% <ø> (ø)
@yoroi/types ∅ <ø> (∅)
@yoroi/wallet-mobile 9.39% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jorbuedo jorbuedo requested a review from stackchain March 28, 2025 11:06
@stackchain
Copy link
Member

stackchain commented Apr 3, 2025

TODO (portfolio only for now)

  • add the logger as dependency
  • fix other requests to be optmistic
  • log problems when parsing with logger.error (will send to sentry if sharing crashes)

@stackchain stackchain marked this pull request as draft April 7, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants