fix(portfolio): further toTokenActivity breaking

packages/portfolio/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yoroi/portfolio",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "The Portfolio package of Yoroi SDK",
   "keywords": [
     "yoroi",

packages/portfolio/src/adapters/dullahan-api/api-maker.test.ts

@@ -290,13 +290,10 @@ describe('portfolioApiMaker', () => {
     })
 
     expect(resultTokenActivity).toEqual({
-      tag: 'left',
-      error: {
-        status: -3,
-        message: 'Failed to transform token activity updates response',
-        responseData: {
-          ['wrong']: [200, 'data'],
-        },
+      tag: 'right',
+      value: {
+        status: 200,
+        data: {},
       },
     })
 

packages/portfolio/src/adapters/dullahan-api/api-maker.ts

@@ -268,35 +268,21 @@ export const portfolioApiMaker = ({
         if (Object.keys(activities).length === 0 && firstError)
           return firstError
 
-        try {
-          const transformedResponseData = toTokenActivity(activities)
-
-          const transformedResponse: Api.Response<Portfolio.Api.TokenActivityResponse> =
-            freeze(
-              {
-                tag: 'right',
-                value: {
-                  status: Api.HttpStatusCode.Ok,
-                  data: transformedResponseData,
-                },
-              },
-              true,
-            )
+        const transformedResponseData = toTokenActivity(activities)
 
-          return transformedResponse
-        } catch (error) {
-          return freeze(
+        const transformedResponse: Api.Response<Portfolio.Api.TokenActivityResponse> =
+          freeze(
             {
-              tag: 'left',
-              error: {
-                status: -3,
-                message: 'Failed to transform token activity updates response',
-                responseData: activities,
+              tag: 'right',
+              value: {
+                status: Api.HttpStatusCode.Ok,
+                data: transformedResponseData,
               },
             },
             true,
           )
-        }
+
+        return transformedResponse
       },
 
       async tokenHistory(tokenId, period) {

packages/portfolio/src/adapters/dullahan-api/transformers.ts

@@ -63,7 +63,8 @@ export const toTokenActivity = (
       const [statusCode, tokenActivityData] = response
       if (statusCode !== Api.HttpStatusCode.Ok) return acc
 
-      TokenActivityResponseSchema.parse(tokenActivityData)
+      if (!TokenActivityResponseSchema.safeParse(tokenActivityData).success)
+        return acc
 
       const parsedTokenActivity: Portfolio.Token.Activity = {
         price: {