Develop #11
Merged
Develop #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved saved token login logic from LoginViewModel to AuthenticatorViewModel for better separation of concerns. Added extensive logging to SecureTokenStorage and various ViewModels. Introduced event-driven OTP verification start after registration. Removed IconPath from ReportDashboard and set static image path in DashboardView.xaml. Added transaction summary calculation to DashboardViewModel.
…wModel Removed dependency on IMessenger and LoginSuccessMessage in TopBarViewModel. Now uses SessionManager to check login state and load user profile directly. Updated ApiService to retrieve token from SessionManager instead of ISecureTokenStorage, simplifying dependency injection and authentication flow.
…ate report generation Replaces ReportDashboard with a new ReportDashboardModel that uses MVVM patterns and logging. Updates DashboardViewModel to use the new model, injects dependencies, and improves report creation logic. Modifies DashboardView and TopBarView to align with the new model and removes fallback values. Updates README with a YouTube video link.
Updated DebtDashboard to use Brush for StatusBrush instead of string. Refactored TopBarViewModel property names for clarity and updated related bindings in TopBarView.xaml. Enhanced BottomBarViewModel with company, version, and sync status properties, and added AddNewTransaction command. Updated BottomBarView.xaml to bind company and version dynamically. Adjusted DashboardViewModel to use Brush resource for StatusBrush.
Added calendar, credit-card, and investment icons to the project and updated resource references. Extended CurrencyModel to include daily low, daily high, weekly change, and monthly change properties. Updated CurrenciesViewModel to populate these new fields and removed redundant properties. Adjusted AccountModel to use new icon paths and improved default icon handling. Updated CurrenciesView.xaml to bind to the new currency statistics.
Renamed 'isUnread' to 'IsUnread' in NotificationModel for consistency with C# naming conventions and updated all references in the ViewModel. Modified NotificationView.xaml to use IsEnabled instead of Visibility for the mark-as-read button, removing the BooleanToVisibilityConverter resource.
Removed unnecessary using directives and adjusted the order of usings in several ViewModel and Model files for improved code clarity. Also removed a redundant MessageBox in LoginViewModel and fixed minor whitespace issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements to the
FinTrackproject, including improved logging, updates to models, and the addition of new properties and methods. Notable changes include integratingILoggerfor better logging across various components, refining model properties for default values and clarity, and restructuring certain features to enhance functionality.Logging Enhancements:
FinTrack/Core/SecureTokenStorage.cs: IntegratedILoggerfor logging token-related operations, replacingConsole.WriteLinestatements with structured logging for better error tracking and information. [1] [2] [3] [4]FinTrack/ViewModels/ApplicationRecognizeSlideViewModel.cs: Added logging for user interactions with application slides, such as navigating forward, backward, or skipping. [1] [2]FinTrack/ViewModels/AuthenticatorViewModel.cs: Implemented logging for token validation and login flow, including handling invalid tokens and saved token login scenarios.FinTrack/ViewModels/BottomBarViewModel.cs: Added logging for interactions with the bottom bar, such as initiating new transactions.Model Updates:
FinTrack/Models/Account/AccountModel.cs: Updatednameproperty to default to an empty string and refinedIconPathlogic for better handling of account types. [1] [2]FinTrack/Models/Currency/CurrencyModel.cs: Added new observable properties (dailyLow,dailyHigh,weeklyChange,monthlyChange) to enhance currency tracking.FinTrack/Models/Dashboard/DebtDashboard.cs: ChangedStatusBrushproperty type toBrushfor better UI integration.Feature Enhancements:
FinTrack/Models/Dashboard/ReportDashboardModel.cs: Replaced theReportDashboardclass with a new MVVM-basedReportDashboardModel, adding support for export formats and a command to generate reports with logging. [1] [2]FinTrack/ViewModels/AuthenticatorViewModel.cs: Added functionality to handle saved token login and token validation, improving user authentication flow.Resource Updates:
FinTrack/FinTrack.csproj: Updated resource paths for icons to ensure consistency and added new icons (calendar,credit-card,investment). [1] [2]Code Cleanup:
FinTrack/Services/Api/ApiService.cs: Removed dependency onISecureTokenStorageand replaced token retrieval logic withSessionManager. [1] [2] [3]FinTrack/ViewModels/CurrenciesViewModel.cs: Removed redundant properties (weeklyChange,monthlyChange) to streamline the view model.