Skip to content

Conversation

@vishesh-sachan
Copy link
Member

@vishesh-sachan vishesh-sachan commented Dec 7, 2025

Fix: Recordings Page Output Folder Button Inconsistency

This fixes the "Open Recordings Folder" button on the Recordings page to respect the user's custom output folder setting from Settings > Recording. Previously, only the Settings page button opened the correct location, while the Recordings page button always opened the hardcoded default app data directory.

The fix ensures both buttons use the same logic: check settings.value['recording.cpal.outputFolder'] first, then fall back to PATHS.DB.RECORDINGS() if not configured.

Key areas affected:

  • Recordings page OpenFolderButton component (/routes/(app)/(config)/recordings/+page.svelte)
  • Both CPAL and FFmpeg recording methods (they share the same output folder setting)

User impact before fix:

  1. User changes output folder in Settings to custom location (e.g., ~/Documents/Recordings)
  2. New recordings are correctly saved to ~/Documents/Recordings
  3. Settings page "Open Folder" button correctly opens ~/Documents/Recordings
  4. Bug: Recordings page "Open Folder" button still opens ~/Library/Application Support/whispering/recordings (default location)

After fix:

Both "Open Output Folder" buttons consistently open the user's configured output folder, making it easy to access recordings from either location in the app.

Type of Change

  • fix: Bug fix

Related Issue

Closes #1106

Screenshot 2025-12-07 at 11 08 38 AM Screenshot 2025-12-07 at 11 09 06 AM

Copy link
Member

@rupokghosh rupokghosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good improvement pr! lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent 'Open Output Folder' Button Behavior Between Settings and Recordings Pages

2 participants