Skip to content

fix(whispering): Recordings Page Output Folder Button Inconsistency #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vishesh-sachan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(whispering): Recordings Page Output Folder Button Inconsistency #1107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions apps/whispering/src/routes/(app)/(config)/recordings/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
import { format } from 'date-fns';
import OpenFolderButton from '$lib/components/OpenFolderButton.svelte';
import { PATHS } from '$lib/constants/paths';
import { settings } from '$lib/stores/settings.svelte';

/**
* Returns a cell renderer for a date/time column using date-fns format.
Expand Down Expand Up @@ -505,8 +506,7 @@
},
onError: (error) => {
rpc.notify.error.execute({
title:
'Error copying transcripts to clipboard',
title: 'Error copying transcripts to clipboard',
description: error.message,
action: { type: 'more-details', error: error },
});
Expand Down Expand Up @@ -560,7 +560,13 @@
{/if}

<OpenFolderButton
getFolderPath={PATHS.DB.RECORDINGS}
getFolderPath={async () => {
// Use the configured output folder if set, otherwise use default
return (
settings.value['recording.cpal.outputFolder'] ??
(await PATHS.DB.RECORDINGS())
);
}}
tooltipText="Open recordings folder"
/>

Expand Down
Loading