fix(deployer): check token version before V2 upgrade #3820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes EspressoSystems#3812 Add version check at the start of upgrade_esp_token_v2() and upgrade_esp_token_v2_multisig_owner() to fail early with a clear error message if the token is already on V2. Previously, attempting to upgrade an already-V2 token would result in a cryptic 'InvalidInitialization' revert (0xf92ee8a9). Now users get a clear message: 'EspToken is already on V2, no upgrade needed'
madisoncarter1234
requested review from
bfish713,
imabdulbasit,
jbearer,
lukaszrzasik,
pls148,
rob-maron,
ss-es and
sveitser
as code owners
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3812
Adds a version check at the start of
upgrade_esp_token_v2()andupgrade_esp_token_v2_multisig_owner()to fail early with a clear error message if the token is already on V2.Before: Attempting to upgrade an already-V2 token resulted in a cryptic
InvalidInitializationrevert (0xf92ee8a9).After: Users get a clear message:
EspToken is already on V2, no upgrade needed