Skip to content

fix(deployer): check token version before V2 upgrade #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
madisoncarter1234 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(deployer): check token version before V2 upgrade #3820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions contracts/rust/deployer/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,6 +857,16 @@ pub async fn upgrade_esp_token_v2(
};

let proxy = EspToken::new(proxy_addr, &provider);

// Check if already on V2
let current_version = proxy.getVersion().call().await?;
if current_version.majorVersion >= 2 {
anyhow::bail!(
"EspToken is already on V{}, no upgrade needed",
current_version.majorVersion
)
}

// Deploy the new implementation
let v2_addr = contracts
.deploy(Contract::EspTokenV2, EspTokenV2::deploy_builder(&provider))
Expand Down
10 changes: 10 additions & 0 deletions contracts/rust/deployer/src/proposals/multisig.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,16 @@ pub async fn upgrade_esp_token_v2_multisig_owner(
.ok_or_else(|| anyhow!("EspTokenProxy (multisig owner) not found, can't upgrade"))?;
tracing::info!("EspTokenProxy found at {proxy_addr:#x}");
let proxy = EspToken::new(proxy_addr, &provider);

// Check if already on V2
let current_version = proxy.getVersion().call().await?;
if current_version.majorVersion >= 2 {
anyhow::bail!(
"EspToken is already on V{}, no upgrade needed",
current_version.majorVersion
)
}

let owner_addr = proxy.owner().call().await?;

if !dry_run {
Expand Down