Refactor to allow adaptive timestepping for overset; improve adaptive timestepping #1542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also avoid CFL warning for end of fixed_dt simulation - also avoid abort when simulation starts with 0 velocity
Contributor
Author
|
Will modify an AMR-Wind reg test to cover these changes, probably the same for exawind-driver |
… unconventional function name)
Contributor
Author
|
Because of the name changes, this should probably be merged the same day as the companion exawind-driver PR, Exawind/exawind-driver#107 |
14 tasks
marchdf
approved these changes
Apr 23, 2025
jrood-nrel
pushed a commit
to jrood-nrel/amr-wind
that referenced
this pull request
Jun 3, 2025
… timestepping (Exawind#1542) * Refactoring to separate computing dt from calculating new_time - also avoid CFL warning for end of fixed_dt simulation - also avoid abort when simulation starts with 0 velocity * Add a maximum dt argument, limit to adaptive timestepping * remove undefined function * rename some functions to go with convention (rather than adding a new unconventional function name) * put new features into existing rain_drop test * fix unit tests * add minimum time feature to abort when velocity becomes too small. * documentation * add consts in compute_dt, limit CFL calculation to non-masked parts of the domain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactoring:
(This allows new functionality for the overset solver)
Features:
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Issue Number: