Skip to content

Conversation

@mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Mar 28, 2025

No description provided.

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Mar 28, 2025

will be incorporating this into a reg test

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Mar 28, 2025

depends on:
AMR-Wind PR
Exawind/amr-wind#1542
Nalu-Wind PR
Exawind/nalu-wind#1366

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Apr 1, 2025

This approach is working for the reg test, but it is not working at scale for an actual run. Nalu-Wind and AMR-Wind end up using different time step sizes. I'm not sure how this is happening. I would suspect that it is a parallelism issue, but every processor should have a valid value of dt, so it doesn't make sense to have it be due to parallelism.

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Apr 1, 2025

Even though each processor has a valid dt, not every processor has both solvers, and usually they're separate. Need an MPI All Reduce min.

@mbkuhn
Copy link
Contributor Author

mbkuhn commented Apr 1, 2025

Reg test still works as a valid test case (revealing the problems at scale) provided that the processors are divided between the two solvers.

@mbkuhn mbkuhn merged commit 421ca84 into Exawind:main Apr 23, 2025
1 of 2 checks passed
@mbkuhn mbkuhn deleted the adaptive_dt branch July 18, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants