[Accessibility] Add missing or change bad media descriptions - #660
Conversation
codeurimpulsif
added
enhancement
9b6791b to
1c9ac6c
Compare
|
Rather than commenting every occurences where this happens, some general comments:
I've looked at some documents for this, I'm still no accessibility expert, though! |
Yes, I don't know why we keep them, maybe it could be a good idea to remove them later.
Yes, I will remove some of them, thanks! |
9c2b2a4 to
76e2b3c
Compare
76e2b3c to
7e1233f
Compare
| read our <a target="_blank" rel="noreferrer" href='https://exodus-privacy.eu.org/en/post/covid/'>blog post</a> | ||
| {% blocktrans %} | ||
| Applications with geographic restrictions cannot be scanned - | ||
| read our <a target="_blank" rel="noreferrer" href='https://exodus-privacy.eu.org/en/post/covid/'>blog post</a> |
There was a problem hiding this comment.
Any specific reason not to use the same quotes for every attribute?
There was a problem hiding this comment.
No, I just don't touche this.
|
|
||
| <div id="loading" class="text-center d-none"> | ||
| <img class="w-200px" src="/static/img/loading.gif" alt=""> | ||
| <img class="w-200px" src="/static/img/loading.gif" alt="{% trans "Animated line of marbles going up and down in waves" %}"> |
There was a problem hiding this comment.
Was there any alt text before helping to understand its role? I'm not sure if describing the animation is a good thing for accessibility here?
There was a problem hiding this comment.
No there wasn't. I think it describe something is happening to see it's loading.
| <a href="#" class="btn btn-primary">{% trans "See the report" %}</a> | ||
| </p> | ||
| <img id="snake" class="d-none w-200px" src="/static/img/loading.gif" alt=""> | ||
| <img id="snake" class="d-none w-200px" src="/static/img/loading.gif" alt="{% trans "Animated line of marbles going up and down in waves" %}"> |
There was a problem hiding this comment.
Was there any alt text before helping to understand its role? I'm not sure if describing the animation is a good thing for accessibility here?
| {% endif %} | ||
| {% if perm.severity == 'Special' or perm.severity == 'Dangerous' %} | ||
| <img data-toggle="tooltip" data-placement="top" title="Protection level: {{ perm.protection_level }}" src="/static/img/danger.svg"> | ||
| <img data-toggle="tooltip" data-placement="top" title="Protection level: {{ perm.protection_level }}" src="/static/img/danger.svg" alt="{% trans "Red exclamation mark" %}"> |
There was a problem hiding this comment.
I would rather replace description by its signification?
There was a problem hiding this comment.
No because the explanation is already here.
| <small class="text-muted font-italic"> | ||
| {% blocktrans trimmed %} | ||
| The icon <img src="/static/img/danger.svg"> indicates a 'Dangerous' or 'Special' level according to <a target="_blank" rel="noreferrer" href="https://developer.android.com/guide/topics/permissions/overview">Google's protection levels</a>. | ||
| The icon <img src="/static/img/danger.svg" alt="Red exclamation mark"> indicates a 'Dangerous' or 'Special' level according to <a target="_blank" rel="noreferrer" href="https://developer.android.com/guide/topics/permissions/overview">Google's protection levels</a>. |
There was a problem hiding this comment.
I would rather replace description by its signification?
There was a problem hiding this comment.
I don't think it's a good idea, but maybe?
There was a problem hiding this comment.
What makes you think it's not a good one?
|
@codeurimpulsif Sorry I took too much time to check again here, added a few comments here and there plus one I didn't target as there are several occurrences: is it a good thing to add description of a logo in the alt text? I'd say it's better to just say it's "XXX logo" and that's all? Or at the very least when the same logo appears more than once, describe it only once. |
|
@Porkepix for the Exodus logo I think it's a good idea, for the contacts logos I don't know, do you think we should change them? |
When I was looking for some information around accessibility topics, I've read one article that was saying one of the best examples they came across was one site with only "foo", "bar" and "baz" as alt text where foo, bar and baz were brand names, therefore not even mentioning the word "logo". Those were links to these brands websites, though. Anyway, it's never easy as you can find contradictory information and I get the feeling there isn't one absolute good/best answer to this. But yeah I wouldn't have put the description or at least only once for my part. |
|
@Porkepix the logos we're talking about are not links, only logo to show it's an email or a social network. |
Yes, but then the meaning is carried by the link beside it, not by the picture that's not used for screen readers, right? |
2 participants
Goal
Information
Need #634 to be merged first.