Skip to content

[Accessibility] Add missing or change bad media descriptions #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeurimpulsif merged 3 commits into from
Jul 27, 2025
Merged

[Accessibility] Add missing or change bad media descriptions #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17186f4
accessibility: add missing or change bad images descriptions
codeurimpulsif Jul 22, 2025
8385e7d
translation: add missing english translations
codeurimpulsif Jul 22, 2025
7e1233f
fix: remove unnecessary image descriptions
codeurimpulsif Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
106 changes: 77 additions & 29 deletions exodus/analysis_query/locale/en/LC_MESSAGES/django.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2021-10-01 10:56+0000\n"
"POT-Creation-Date: 2025-07-23 16:39+0000\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
Expand Down Expand Up @@ -41,107 +41,155 @@ msgstr ""
msgid "You need to be registered"
msgstr ""

#: analysis_query/templates/query_error.html:3
#: analysis_query/templates/query_error.html:4
msgid "Error during an analysis"
msgstr ""

#: analysis_query/templates/query_error.html:5
#: analysis_query/templates/query_error.html:6
#: analysis_query/templates/query_submit.html:8
#: analysis_query/templates/query_submit.html:9
#: analysis_query/templates/query_submit.html:15
#: analysis_query/templates/query_upload.html:8
#: analysis_query/templates/query_upload.html:9
#: analysis_query/templates/query_upload.html:15
#: analysis_query/templates/query_wait.html:8
#: analysis_query/templates/query_wait.html:9
msgid "New analysis"
msgstr ""

#: analysis_query/templates/query_submit.html:21
#: analysis_query/templates/query_submit.html:6
#: analysis_query/templates/query_submit.html:7
msgid "Submit an application handle or URL to run a new analysis"
msgstr ""

#: analysis_query/templates/query_submit.html:27
msgid ""
"It is currently impossible to submit new analysis. Sorry for the "
"inconvenience!"
msgstr ""

#: analysis_query/templates/query_submit.html:36
#: analysis_query/templates/query_submit.html:42
msgid "URL of the application"
msgstr ""

#: analysis_query/templates/query_submit.html:45
#: analysis_query/templates/query_submit.html:46
msgid "Search"
msgstr ""

#: analysis_query/templates/query_submit.html:51
msgid "Source:"
msgstr ""

#: analysis_query/templates/query_submit.html:55
#: analysis_query/templates/query_submit.html:61
msgid "Free applications only. Works also with the application handle."
msgstr ""

#: analysis_query/templates/query_submit.html:67
#: analysis_query/templates/query_upload.html:50
#: analysis_query/templates/query_submit.html:64
msgid ""
"\n"
" Applications with geographic restrictions cannot be scanned "
"-\n"
" read our <a target=\"_blank\" rel=\"noreferrer\" "
"href='https://exodus-privacy.eu.org/en/post/covid/'>blog post</a>\n"
" "
msgstr ""

#: analysis_query/templates/query_submit.html:75
#: analysis_query/templates/query_upload.html:56
msgid "Perform analysis"
msgstr ""

#: analysis_query/templates/query_submit.html:73
#: analysis_query/templates/query_submit.html:81
msgid "I prefer to upload an application"
msgstr ""

#: analysis_query/templates/query_submit.html:80
#: analysis_query/templates/query_upload.html:57
#: analysis_query/templates/query_submit.html:86
#: analysis_query/templates/query_upload.html:61
#: analysis_query/templates/query_wait.html:32
msgid "Animated line of marbles going up and down in waves"
msgstr ""

#: analysis_query/templates/query_submit.html:88
#: analysis_query/templates/query_upload.html:63
msgid ""
"The analysis could take a long time, you will be automatically redirected to "
"the report."
msgstr ""

#: analysis_query/templates/query_submit.html:94
#: analysis_query/templates/query_upload.html:70
#: analysis_query/templates/query_wait.html:39
#: analysis_query/templates/query_submit.html:102
#: analysis_query/templates/query_upload.html:76
#: analysis_query/templates/query_wait.html:45
msgid "is a non-profit organization which provides this service for free."
msgstr ""

#: analysis_query/templates/query_submit.html:96
#: analysis_query/templates/query_upload.html:72
#: analysis_query/templates/query_wait.html:41
#: analysis_query/templates/query_submit.html:104
#: analysis_query/templates/query_upload.html:78
#: analysis_query/templates/query_wait.html:47
msgid "Help us!"
msgstr ""

#: analysis_query/templates/query_submit.html:132
#: analysis_query/templates/query_submit.html:140
msgid "This application has already been analyzed!"
msgstr ""

#: analysis_query/templates/query_submit.html:138
#: analysis_query/templates/query_submit.html:146
msgid "analyzed on"
msgstr ""

#: analysis_query/templates/query_submit.html:138
#: analysis_query/templates/query_submit.html:146
msgid "Go to the latest report"
msgstr ""

#: analysis_query/templates/query_submit.html:142
#: analysis_query/templates/query_submit.html:150
msgid ""
"If you think εxodus has not yet analyzed the latest version of this "
"application, feel free to submit the analysis."
msgstr ""

#: analysis_query/templates/query_upload.html:32
#: analysis_query/templates/query_upload.html:6
#: analysis_query/templates/query_upload.html:7
msgid "Upload an APK file to run a new analysis"
msgstr ""

#: analysis_query/templates/query_upload.html:38
msgid "Upload an application"
msgstr ""

#: analysis_query/templates/query_upload.html:36
#: analysis_query/templates/query_upload.html:42
msgid "Browse file"
msgstr ""

#: analysis_query/templates/query_upload.html:42
#: analysis_query/templates/query_upload.html:48
msgid "Only works with APK files."
msgstr ""

#: analysis_query/templates/query_wait.html:9
#: analysis_query/templates/query_wait.html:6
#: analysis_query/templates/query_wait.html:7
msgid "In progress or completed analysis"
msgstr ""

#: analysis_query/templates/query_wait.html:15
msgid "Analysis in progress..."
msgstr ""

#: analysis_query/templates/query_wait.html:24
#: analysis_query/templates/query_wait.html:30
msgid "See the report"
msgstr ""

#: analysis_query/templates/query_wait.html:28
#: analysis_query/templates/query_wait.html:34
msgid "Will refresh automatically every 10 seconds."
msgstr ""

#: analysis_query/templates/query_wait.html:64
#: analysis_query/templates/query_wait.html:68
msgid "Analysis done!"
msgstr ""

#: analysis_query/views.py:34 analysis_query/views.py:62
#: analysis_query/views.py:34 analysis_query/views.py:66
msgid "Your request will be handled soon"
msgstr ""

#: analysis_query/views.py:76 analysis_query/views.py:84
#: analysis_query/views.py:80 analysis_query/views.py:88
msgid "AnalysisRequest does not exist"
msgstr ""
12 changes: 7 additions & 5 deletions exodus/analysis_query/templates/query_submit.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ <h1 class="main-title">
<div class="row justify-content-sm-center">
<div class="col-md-8 col-12">
<p class="text-center mb-5">
<img src="{% static 'img/analysis_new.png' %}" width="120">
<img src="{% static 'img/analysis_new.png' %}" width="120" alt="">
</p>
{% if submissions_disabled and not request.user.is_superuser %}
<div class="text-center alert alert-danger">
Expand All @@ -43,7 +43,7 @@ <h1 class="main-title">
<div class="input-group input-group-lg mb-3">
<div class="input-group-prepend">
<span class="input-group-text" id="handle_help">
<small><img src="/static/img/search.svg"></small>
<small><img src="/static/img/search.svg" alt="{% trans "Search" %}"></small>
</span>
</div>
<input type="text" class="form-control" id="handle" name="handle" aria-describedby="handle_help" required>
Expand All @@ -61,8 +61,10 @@ <h1 class="main-title">
{% trans "Free applications only. Works also with the application handle." %}
</p>
<div class="alert alert-warning text-center mb-4" role="alert">
Applications with geographic restrictions cannot be scanned -
read our <a target="_blank" rel="noreferrer" href='https://exodus-privacy.eu.org/en/post/covid/'>blog post</a>
{% blocktrans %}
Applications with geographic restrictions cannot be scanned -
read our <a target="_blank" rel="noreferrer" href='https://exodus-privacy.eu.org/en/post/covid/'>blog post</a>

@Porkepix Porkepix Jul 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any specific reason not to use the same quotes for every attribute?

@codeurimpulsif codeurimpulsif Jul 27, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I just don't touche this.

{% endblocktrans %}
</div>

<div id="reports" class="alert alert-info d-none">
Expand All @@ -81,7 +83,7 @@ <h1 class="main-title">
{% endif %}

<div id="loading" class="text-center d-none">
<img class="w-200px" src="/static/img/loading.gif" alt="">
<img class="w-200px" src="/static/img/loading.gif" alt="{% trans "Animated line of marbles going up and down in waves" %}">
<div class="alert alert-light" role="alert">
{% trans "The analysis could take a long time, you will be automatically redirected to the report." %}
</div>
Expand Down
4 changes: 2 additions & 2 deletions exodus/analysis_query/templates/query_upload.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ <h1 class="main-title">
<div class="row justify-content-sm-center">
<div class="col-md-8 col-12">
<p class="text-center mb-5">
<img src="{% static 'img/analysis_new.png' %}" width=120px>
<img src="{% static 'img/analysis_new.png' %}" width=120px alt="">
</p>
<form method="post" enctype="multipart/form-data" action="{% url 'analysis:upload' %}">
<div class="form-group">
Expand Down Expand Up @@ -58,7 +58,7 @@ <h1 class="main-title">
</div>

<div id="loading" class="text-center d-none">
<img class="w-200px" src="/static/img/loading.gif" alt="">
<img class="w-200px" src="/static/img/loading.gif" alt="{% trans "Animated line of marbles going up and down in waves" %}">

@Porkepix Porkepix Jul 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there any alt text before helping to understand its role? I'm not sure if describing the animation is a good thing for accessibility here?

@codeurimpulsif codeurimpulsif Jul 27, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No there wasn't. I think it describe something is happening to see it's loading.

<div class="alert alert-light" role="alert">
{% trans "The analysis could take a long time, you will be automatically redirected to the report." %}
</div>
Expand Down
4 changes: 2 additions & 2 deletions exodus/analysis_query/templates/query_wait.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,12 @@ <h1 id="main-title" class="main-title">
{% trans analysis.description %}
</div>
<p id="completed" class="text-center mt-5 d-none">
<img src="{% static 'img/analysis_completed.png' %}" width="120">
<img src="{% static 'img/analysis_completed.png' %}" width="120" alt="">
</p>
<p id="report" class="mt-4 d-none">
<a href="#" class="btn btn-primary">{% trans "See the report" %}</a>
</p>
<img id="snake" class="d-none w-200px" src="/static/img/loading.gif" alt="">
<img id="snake" class="d-none w-200px" src="/static/img/loading.gif" alt="{% trans "Animated line of marbles going up and down in waves" %}">

@Porkepix Porkepix Jul 27, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there any alt text before helping to understand its role? I'm not sure if describing the animation is a good thing for accessibility here?

@codeurimpulsif codeurimpulsif Jul 27, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

<div id="refresh" class="text-muted small">
{% trans "Will refresh automatically every 10 seconds." %}
</div>
Expand Down
Loading
Loading