Skip to content

Add CSpell for spelling checks #59249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 47 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
16891ac
feat: cspell
kirillzyusko Feb 3, 2025
47a2ec9
feat: actually start implementation
kirillzyusko Feb 3, 2025
b17d3c9
feat: more updates
kirillzyusko Feb 3, 2025
b1a31a8
feat: only 6k spells left
kirillzyusko Feb 3, 2025
d34469f
feat: move further
kirillzyusko Feb 3, 2025
292b5b1
feat: only 2912 spells left
kirillzyusko Feb 3, 2025
d448620
feat: only 2250 spells left
kirillzyusko Feb 3, 2025
0c78eb7
feat: 1700 spells left
kirillzyusko Feb 4, 2025
a7279dc
Merge branch 'main' into feat/cspell
kirillzyusko Feb 4, 2025
1f31305
Merge branch 'main' into feat/cspell
kirillzyusko Mar 17, 2025
174cdee
fix: ts
kirillzyusko Mar 17, 2025
a77f866
fix: resolve correct file
kirillzyusko Mar 17, 2025
376b2cb
Merge branch 'main' of github.com:dominictb/epsf-app into vit-56230
dominictb Mar 27, 2025
100a67b
637 errors left
dominictb Mar 26, 2025
826dacb
add Spanish support
dominictb Mar 26, 2025
a9dac32
Merge branch 'main' of github.com:dominictb/epsf-app into feat/54810-…
dominictb Mar 27, 2025
4199bbc
701 words left
dominictb Mar 27, 2025
2a8e080
516 words left
dominictb Mar 27, 2025
99bbd6c
379 words left
dominictb Mar 27, 2025
7412a1b
Merge branch 'main' of github.com:dominictb/epsf-app into feat/54810-…
dominictb Mar 27, 2025
805cd7e
Update Mobile-Expensify
dominictb Mar 27, 2025
e3ddf01
107 words left
dominictb Mar 27, 2025
3ea165a
done
dominictb Mar 28, 2025
ae00ea0
Merge branch 'main' of github.com:dominictb/epsf-app into feat/54810-…
dominictb Mar 28, 2025
2efb3a8
fix typescript
dominictb Mar 28, 2025
940b540
fix tests
dominictb Mar 28, 2025
de592fd
fix test
dominictb Mar 28, 2025
a45253b
fix lint
dominictb Mar 28, 2025
d9551d0
fix lint
dominictb Mar 28, 2025
5272b15
fix more lint
dominictb Mar 31, 2025
1eabc7f
Merge branch 'main' of github.com:dominictb/epsf-app into feat/54810-…
dominictb Mar 31, 2025
496eb18
fix more lint
dominictb Mar 31, 2025
1ab84b7
Merge branch 'main' of github.com:dominictb/epsf-app into feat/54810-…
dominictb Apr 2, 2025
a68e782
more spelling errors
dominictb Apr 2, 2025
29e3eda
Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…
dominictb Apr 4, 2025
280852d
more words
dominictb Apr 4, 2025
b940d33
prettier
dominictb Apr 4, 2025
081b56c
Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…
dominictb Apr 8, 2025
e566a02
more words
dominictb Apr 8, 2025
f1e553a
update Mobile-Expensify module
dominictb Apr 8, 2025
a85fc1f
prettier
dominictb Apr 8, 2025
2642fe9
Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…
dominictb Apr 9, 2025
821e428
more words
dominictb Apr 9, 2025
db9cee5
update Mobile-Expensify
dominictb Apr 9, 2025
4e9ded9
update NAICS
dominictb Apr 9, 2025
8859e4d
Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…
dominictb Apr 9, 2025
70f409e
more words
dominictb Apr 9, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Mobile-Expensify
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

13 changes: 1 addition & 12 deletions src/components/MoneyReportHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -431,18 +431,7 @@
};

const statusBarProps = getStatusBarProps();
const shouldAddGapToContents =
shouldUseNarrowLayout &&
(isDuplicate || shouldShowSettlementButton || !!shouldShowExportIntegrationButton || shouldShowSubmitButton || shouldShowMarkAsCashButton) &&
(!!statusBarProps || shouldShowNextStep);

// The submit button should be success green color only if the user is the submitter and the policy does not have Scheduled Submit turned on
const isWaitingForSubmissionFromCurrentUser = useMemo(() => isWaitingForSubmissionFromCurrentUserReportUtils(chatReport, policy), [chatReport, policy]);

const shouldDuplicateButtonBeSuccess = useMemo(
() => isDuplicate && !shouldShowSettlementButton && !shouldShowExportIntegrationButton && !shouldShowSubmitButton && !shouldShowMarkAsCashButton,
[isDuplicate, shouldShowSettlementButton, shouldShowExportIntegrationButton, shouldShowSubmitButton, shouldShowMarkAsCashButton],
);
const shouldAddGapToContents = shouldUseNarrowLayout && (!!statusBarProps || shouldShowNextStep);

useEffect(() => {
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
Expand Down Expand Up @@ -551,7 +540,7 @@
return getSecondaryReportActions(moneyRequestReport, transactions, violations, policy);
}, [moneyRequestReport, policy, transactions, violations]);

const secondaryActionsImplemenation: Record<ValueOf<typeof CONST.REPORT.SECONDARY_ACTIONS>, DropdownOption<ValueOf<typeof CONST.REPORT.SECONDARY_ACTIONS>>> = {

Check failure on line 543 in src/components/MoneyReportHeader.tsx

View workflow job for this annotation

GitHub Actions / 🔍 spellcheck

Unknown word (Implemenation)
[CONST.REPORT.SECONDARY_ACTIONS.VIEW_DETAILS]: {
value: CONST.REPORT.SECONDARY_ACTIONS.VIEW_DETAILS,
text: translate('iou.viewDetails'),
Expand Down Expand Up @@ -674,7 +663,7 @@
},
};

const applicableSecondaryActions = secondaryActions.map((action) => secondaryActionsImplemenation[action]);

Check failure on line 666 in src/components/MoneyReportHeader.tsx

View workflow job for this annotation

GitHub Actions / 🔍 spellcheck

Unknown word (Implemenation)

const shouldShowBackButton = shouldDisplayBackButton || shouldUseNarrowLayout;

Expand Down Expand Up @@ -820,7 +809,7 @@
if (!requestParentReportAction || !transaction?.transactionID) {
throw new Error('Missing data!');
}
// it's deleting transacation but not the report which leads to bug (that is actually also on staging)

Check failure on line 812 in src/components/MoneyReportHeader.tsx

View workflow job for this annotation

GitHub Actions / 🔍 spellcheck

Unknown word (transacation)
deleteMoneyRequest(transaction?.transactionID, requestParentReportAction);
goBackRoute = getNavigationUrlOnMoneyRequestDelete(transaction.transactionID, requestParentReportAction, false);
}
Expand Down
14 changes: 7 additions & 7 deletions src/components/ReportActionItem/ExportWithDropdownMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ import ConfirmModal from '@components/ConfirmModal';
import useLocalize from '@hooks/useLocalize';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import useThemeStyles from '@hooks/useThemeStyles';
import {savePreferredExportMethod as savePreferredExportMethodAction} from '@libs/actions/Policy/Policy';
import {savePreferredExportMethod as savePreferredExportMethodUtils} from '@libs/actions/Policy/Policy';
import {exportToIntegration, markAsManuallyExported} from '@libs/actions/Report';
import {hasIntegrationAutoSync as hasIntegrationAutoSyncUtil} from '@libs/PolicyUtils';
import {canBeExported as canBeExportedUtil, getIntegrationIcon, isExported as isExportedUtil} from '@libs/ReportUtils';
import {hasIntegrationAutoSync as hasIntegrationAutoSyncUtils} from '@libs/PolicyUtils';
import {canBeExported as canBeExportedUtils, getIntegrationIcon, isExported as isExportedUtils} from '@libs/ReportUtils';
import type {ExportType} from '@pages/home/report/ReportDetailsExportPage';
import variables from '@styles/variables';
import CONST from '@src/CONST';
Expand Down Expand Up @@ -52,9 +52,9 @@ function ExportWithDropdownMenu({
const [reportActions] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`);

const iconToDisplay = getIntegrationIcon(connectionName);
const canBeExported = canBeExportedUtil(report);
const isExported = isExportedUtil(reportActions);
const hasIntegrationAutoSync = hasIntegrationAutoSyncUtil(policy, connectionName);
const canBeExported = canBeExportedUtils(report);
const isExported = isExportedUtils(reportActions);
const hasIntegrationAutoSync = hasIntegrationAutoSyncUtils(policy, connectionName);
const flattenedWrapperStyle = StyleSheet.flatten([styles.flex1, wrapperStyle]);

const dropdownOptions: Array<DropdownOption<ReportExportType>> = useMemo(() => {
Expand Down Expand Up @@ -103,7 +103,7 @@ function ExportWithDropdownMenu({
if (!report?.policyID) {
return;
}
savePreferredExportMethodAction(report?.policyID, value);
savePreferredExportMethodUtils(report?.policyID, value);
};

return (
Expand Down
1 change: 0 additions & 1 deletion src/libs/PolicyUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1534,7 +1534,6 @@ export {
isWorkspaceEligibleForReportChange,
getManagerAccountID,
isPreferredExporter,
isAutoSyncEnabled,
areAllGroupPoliciesExpenseChatDisabled,
};

Expand Down
3 changes: 1 addition & 2 deletions src/libs/ReportPrimaryActionUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,13 @@ import CONST from '@src/CONST';
import type {Policy, Report, Transaction, TransactionViolation} from '@src/types/onyx';
import {isApprover as isApproverUtils} from './actions/Policy/Member';
import {getCurrentUserAccountID} from './actions/Report';
import {arePaymentsEnabled as arePaymentsEnabledUtils, getCorrectedAutoReportingFrequency, hasAccountingConnections, isAutoSyncEnabled, isPreferredExporter} from './PolicyUtils';
import {
arePaymentsEnabled as arePaymentsEnabledUtils,
getConnectedIntegration,
getCorrectedAutoReportingFrequency,
hasAccountingConnections,
hasIntegrationAutoSync,
isPrefferedExporter,
isPreferredExporter,
} from './PolicyUtils';
import {getAllReportActions, getOneTransactionThreadReportID} from './ReportActionsUtils';
import {
Expand Down
4 changes: 3 additions & 1 deletion src/libs/ReportSecondaryActionUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
hasAccountingConnections,
hasIntegrationAutoSync,
hasNoPolicyOtherThanPersonalType,
isAutoSyncEnabled,
isPreferredExporter,
isWorkspaceEligibleForReportChange,
} from './PolicyUtils';
import {getIOUActionForReportID, getReportActions, isPayAction} from './ReportActionsUtils';
import {
Expand Down Expand Up @@ -218,6 +218,8 @@
return false;
}

const isAdmin = policy?.role === CONST.POLICY.ROLE.ADMIN;

const isExporter = isPreferredExporter(policy);

return isAdmin || isExporter;
Expand All @@ -231,11 +233,11 @@
return false;
}

const isTransactionOnHold = isHoldActionForTransation(report, transaction);

Check failure on line 236 in src/libs/ReportSecondaryActionUtils.ts

View workflow job for this annotation

GitHub Actions / 🔍 spellcheck

Unknown word (Transation)
return isTransactionOnHold;
}

function isHoldActionForTransation(report: Report, reportTransaction: Transaction): boolean {

Check failure on line 240 in src/libs/ReportSecondaryActionUtils.ts

View workflow job for this annotation

GitHub Actions / 🔍 spellcheck

Unknown word (Transation)
const isExpenseReport = isExpenseReportUtils(report);

if (!isExpenseReport) {
Expand Down Expand Up @@ -402,7 +404,7 @@
function getSecondaryTransactionThreadActions(parentReport: Report, reportTransaction: Transaction): Array<ValueOf<typeof CONST.REPORT.TRANSACTION_SECONDARY_ACTIONS>> {
const options: Array<ValueOf<typeof CONST.REPORT.TRANSACTION_SECONDARY_ACTIONS>> = [];

if (isHoldActionForTransation(parentReport, reportTransaction)) {

Check failure on line 407 in src/libs/ReportSecondaryActionUtils.ts

View workflow job for this annotation

GitHub Actions / 🔍 spellcheck

Unknown word (Transation)
options.push(CONST.REPORT.TRANSACTION_SECONDARY_ACTIONS.HOLD);
}

Expand Down
9 changes: 0 additions & 9 deletions src/libs/TransactionUtils/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -891,15 +891,6 @@ function shouldShowBrokenConnectionViolationForMultipleTransactions(
return shouldShowBrokenConnectionViolationInternal(brokenConnectionViolations, report, policy);
}

function checkIfShouldShowMarkAsCashButton(hasRTERPendingViolation: boolean, shouldDisplayBrokenConnectionViolation: boolean, report: OnyxEntry<Report>, policy: OnyxEntry<Policy>) {
if (hasRTERPendingViolation) {
return true;
}
return (
shouldDisplayBrokenConnectionViolation && (!isPolicyAdmin(policy) || isCurrentUserSubmitter(report?.reportID)) && !isReportApproved({report}) && !isReportManuallyReimbursed(report)
);
}

/**
* Check if there is pending rter violation in all transactionViolations with given transactionIDs.
*/
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.