Add `CSpell` for spelling checks #59249

dominictb · 2025-03-27T18:24:57Z

Explanation of Change

Fixed Issues

$ #54810
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…cspell

github-actions · 2025-03-27T18:25:08Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-03-27T18:53:25Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

…cspell

github-actions · 2025-03-27T18:54:40Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-03-27T18:55:08Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-03-27T19:31:27Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-03-28T04:40:48Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

…cspell

ishpaul777 · 2025-04-05T21:41:14Z

src/pages/EnablePayments/utils/getSubStepValues.tsx

Not a bug, but i think there's no need to change it to .tsx ?

ishpaul777 · 2025-04-05T21:41:30Z

src/pages/EnablePayments/utils/getInitialSubStepForPersonalInfo.tsx

same comment as ^

ishpaul777 · 2025-04-07T12:26:13Z

Expect to finish rest of the review today

ishpaul777 · 2025-04-07T22:14:09Z

reviewed rest of file changes it mostly LGTM! @dominictb please resolve conflicts when you get the chance, we have some tests failing

…eat/54810-cspell

github-actions · 2025-04-08T08:15:55Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-08T08:18:58Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-08T08:20:24Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

github-actions · 2025-04-08T08:42:35Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

dominictb · 2025-04-08T11:25:09Z

@ishpaul777 Done

…eat/54810-cspell

dominictb · 2025-04-09T09:08:41Z

@ishpaul777 Done!

mountiny · 2025-04-09T11:47:00Z

Mobile-Expensify

This should be removed

…eat/54810-cspell

mountiny · 2025-04-09T16:40:54Z

@dominictb Ok I think this might be really tricky to get merged, could you maybe split this up to smaller PRs where we update the spellings without adding the action just yet and we will add the action in the last PR

dominictb · 2025-04-09T17:04:52Z

@mountiny What is "action" that you mentioned?

ishpaul777 · 2025-04-09T19:47:30Z

What is "action" that you mentioned?

i beleive the github workflow which will check the spelling mistakes and fails on PR

mountiny · 2025-04-10T13:32:54Z

Yeah what @ishpaul777 meant

mountiny · 2025-04-14T16:14:32Z

@dominictb how is this looking, did you get a chance to split this up to smaller PRs?

dominictb · 2025-04-14T18:57:33Z

I'm progressing like 20% of these but some commits are dependent on each other so it might take more time. Will finish in 1 - 2 days.

kirillzyusko and others added 18 commits February 3, 2025 11:51

feat: cspell

16891ac

feat: actually start implementation

47a2ec9

feat: more updates

b17d3c9

feat: only 6k spells left

b1a31a8

feat: move further

d34469f

feat: only 2912 spells left

292b5b1

feat: only 2250 spells left

d448620

feat: 1700 spells left

0c78eb7

Merge branch 'main' into feat/cspell

a7279dc

Merge branch 'main' into feat/cspell

1f31305

fix: ts

174cdee

fix: resolve correct file

a77f866

Merge branch 'main' of github.com:dominictb/epsf-app into vit-56230

376b2cb

637 errors left

100a67b

add Spanish support

826dacb

Merge branch 'main' of github.com:dominictb/epsf-app into feat/54810-…

a9dac32

…cspell

701 words left

4199bbc

516 words left

2a8e080

379 words left

99bbd6c

Merge branch 'main' of github.com:dominictb/epsf-app into feat/54810-…

7412a1b

…cspell

Update Mobile-Expensify

805cd7e

107 words left

e3ddf01

done

3ea165a

Merge branch 'main' of github.com:dominictb/epsf-app into feat/54810-…

ae00ea0

…cspell

ishpaul777 reviewed Apr 5, 2025

View reviewed changes

src/pages/EnablePayments/utils/getSubStepValues.tsx Outdated

Copy link

Contributor

ishpaul777 Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bug, but i think there's no need to change it to .tsx ?

ishpaul777 reviewed Apr 5, 2025

View reviewed changes

src/pages/EnablePayments/utils/getInitialSubStepForPersonalInfo.tsx Outdated

Copy link

Contributor

ishpaul777 Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as ^

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…

081b56c

…eat/54810-cspell

more words

e566a02

update Mobile-Expensify module

f1e553a

prettier

a85fc1f

dominictb added 3 commits April 9, 2025 15:39

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…

2642fe9

…eat/54810-cspell

more words

821e428

update Mobile-Expensify

db9cee5

update NAICS

4e9ded9

mountiny reviewed Apr 9, 2025

View reviewed changes

dominictb added 2 commits April 9, 2025 22:43

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into f…

8859e4d

…eat/54810-cspell

more words

70f409e

This was referenced Apr 17, 2025

[NoQA] Add CSpell for spelling checks [Part 1] #60385

Open

[NoQA] Add CSpell for spelling checks [Part 2] #60393

Open

dominictb closed this Apr 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `CSpell` for spelling checks #59249

Add `CSpell` for spelling checks #59249

dominictb commented Mar 27, 2025

github-actions bot commented Mar 27, 2025

github-actions bot commented Mar 27, 2025

github-actions bot commented Mar 27, 2025

github-actions bot commented Mar 27, 2025

github-actions bot commented Mar 27, 2025

github-actions bot commented Mar 28, 2025

ishpaul777 Apr 5, 2025

ishpaul777 Apr 5, 2025

ishpaul777 commented Apr 7, 2025

ishpaul777 commented Apr 7, 2025 •

edited

Loading

github-actions bot commented Apr 8, 2025

github-actions bot commented Apr 8, 2025

github-actions bot commented Apr 8, 2025

github-actions bot commented Apr 8, 2025

dominictb commented Apr 8, 2025

dominictb commented Apr 9, 2025

mountiny Apr 9, 2025

dominictb Apr 9, 2025

mountiny commented Apr 9, 2025

dominictb commented Apr 9, 2025

ishpaul777 commented Apr 9, 2025

mountiny commented Apr 10, 2025

mountiny commented Apr 14, 2025

dominictb commented Apr 14, 2025

Add CSpell for spelling checks #59249

Add CSpell for spelling checks #59249

Conversation

dominictb commented Mar 27, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Mar 27, 2025

github-actions bot commented Mar 27, 2025

github-actions bot commented Mar 27, 2025

github-actions bot commented Mar 27, 2025

github-actions bot commented Mar 27, 2025

github-actions bot commented Mar 28, 2025

ishpaul777 Apr 5, 2025

Choose a reason for hiding this comment

ishpaul777 Apr 5, 2025

Choose a reason for hiding this comment

ishpaul777 commented Apr 7, 2025

ishpaul777 commented Apr 7, 2025 • edited Loading

github-actions bot commented Apr 8, 2025

github-actions bot commented Apr 8, 2025

github-actions bot commented Apr 8, 2025

github-actions bot commented Apr 8, 2025

dominictb commented Apr 8, 2025

dominictb commented Apr 9, 2025

mountiny Apr 9, 2025

Choose a reason for hiding this comment

dominictb Apr 9, 2025

Choose a reason for hiding this comment

mountiny commented Apr 9, 2025

dominictb commented Apr 9, 2025

ishpaul777 commented Apr 9, 2025

mountiny commented Apr 10, 2025

mountiny commented Apr 14, 2025

dominictb commented Apr 14, 2025

Add `CSpell` for spelling checks #59249

Add `CSpell` for spelling checks #59249

ishpaul777 commented Apr 7, 2025 •

edited

Loading