-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add iOS In-App Provisioning #59712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mountiny
merged 45 commits into
Expensify:main
from
software-mansion-labs:@Skalakid/add-to-apple-wallet
Apr 10, 2025
Merged
Add iOS In-App Provisioning #59712
Changes from 36 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
edb5b43
Initialisation
zfurtak a607ca7
merge
zfurtak e8bc8a9
Split code to proper files
zfurtak 2242ed9
Merge branch 'main' into @zfurtak/introduce-wallet-to-expensify
Skalakid 4b8c957
Merge branch 'main' into @zfurtak/introduce-wallet-to-expensify
Skalakid 1e75c63
Add expensify-react-native-wallet tgz
Skalakid 0ae96f8
Fix TS errors
Skalakid 104e762
Fix API call arguments
Skalakid 7d42072
Move wallet tgz
Skalakid 067c153
Update wallet module
Skalakid 6a7f9c6
Add In-App Provisioning util functions
Skalakid 34039ea
Enhance 'Add to Apple Wallet' button component
Skalakid 4d40ba3
Merge branch 'main' into @Skalakid/add-to-apple-wallet
Skalakid a32ea52
Hide in app provisioning behind the beta
Skalakid f0d53b9
Merge branch 'main' into @Skalakid/add-to-apple-wallet
Skalakid 78f80e4
Fix iOS Card Data
Skalakid 5995fbb
Change cardHolderName to user display name
Skalakid cf91bae
Clean up AddToWalletButton
Skalakid 7d4d677
Check if card in the Wallet after finishing push provisioning
Skalakid beb2fc3
Remove text styles
Skalakid a9e1777
Update package-lock.json
Skalakid 44b073e
Update submodule
Skalakid a425e28
Refinements
zfurtak 610d0e5
Fix launching web
Skalakid 2d1d3b6
Update module
Skalakid e18070c
Update package-lock
Skalakid 0cae5a9
Add logs
Skalakid ed0d5a8
Remove unnecessary comment
Skalakid 5c46124
Rename command key
Skalakid 1ad7e76
Fix tests
zfurtak 45598db
Mobile Expensify
zfurtak 5189b1b
Move wallet tgz to module folder
Skalakid 6602d1e
Update module
Skalakid d573f05
Unlink Wallet library from Android
Skalakid 3907881
Remove unnecessary comment
Skalakid 46b9f71
Adjust to review comments
zfurtak 3c87542
Add review changes
Skalakid d7fef51
Update package-lock.json
Skalakid bbd98cd
Rename component in Card Page
Skalakid 8d07876
Merge branch 'main' into @Skalakid/add-to-apple-wallet
Skalakid 6434667
Update Mobile-Expensify version
zfurtak ba575dc
Merge branch 'main' into @Skalakid/add-to-apple-wallet
Skalakid 7c2607b
Merge branch 'main' into @Skalakid/add-to-apple-wallet
Skalakid 5a7a38e
Change card description to translated one
Skalakid 9b9b68a
Update submodule
Skalakid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
type CreateAppleSigitalWalletParams = { | ||
platform: string; | ||
appVersion: string; | ||
// stringified {"certificates": string[]} | ||
certificates: string; | ||
nonce: string; | ||
nonceSignature: string; | ||
}; | ||
|
||
export default CreateAppleSigitalWalletParams; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment indicating it looks like this?
"['cert1', 'cert2']"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's more like a result of this:
JSON.stringify({"certificates": ['cert1', 'cert2']})
. That's how it works on the OldDot 😅 I think we can change this later on the backend to just['cert1', 'cert2']
. What do you think about it?