-
Notifications
You must be signed in to change notification settings - Fork 1.3k
bgpd: fix to show exist/non-exist-map in 'show run' properly #18828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpd: fix to show exist/non-exist-map in 'show run' properly #18828
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a topotest verifying this.
Can you also show this how it looks in |
Before fix:
UT after fix:
|
@Mergifyio backport stable/10.3 stable/10.2 stable/10.1 stable/10.0 |
✅ Backports have been created
|
@Mergifyio rebase |
Currently, peergroup_filter_check() does not check whether exist-map or non-exist-map is configured along with advertise-map. This check is missing only when the peer is part of peergroup and having the exist/non-exist-map. So the 'show run' does not show the configured exist/non-exist-map as expected. This new check is needed because, unlike other filter type the adv-map can have exist/non-exist-map additionally and we don't store this in the filter_override but store only the adv-map. So, a specific check is required to account the exist/non-exist-map while printing the adv-map config. Fixing the same by adding a check. Signed-off-by: Krishnasamy <[email protected]>
✅ Branch has been successfully rebased |
aff1639
to
aa012d8
Compare
done |
done |
Please fix frrbot (python styling) and good to merge. |
25a2c43
to
5b7a0a1
Compare
Signed-off-by: Krishnasamy <[email protected]>
5b7a0a1
to
f15cb73
Compare
done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
bgpd: fix to show exist/non-exist-map in 'show run' properly (backport #18828)
bgpd: fix to show exist/non-exist-map in 'show run' properly (backport #18828)
Currently, peergroup_filter_check() does not check whether exist-map or non-exist-map is configured along with advertise-map. This check is missing only when the peer is part of peergroup and having the exist/non-exist-map. So the 'show run' does not show the configured exist/non-exist-map as expected.
This new check is needed because, unlike other filter type the adv-map can have exist/non-exist-map additionally and we don't store this in the filter_override but store only the adv-map. So, a specific check is required to account the exist/non-exist-map while printing the adv-map config. Fixing the same by adding a check.