bgpd: fix to show exist/non-exist-map in 'show run' properly #18828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
requested changes
May 16, 2025
|
Can you also show this how it looks in |
Before fix:UT after fix: |
|
@Mergifyio backport stable/10.3 stable/10.2 stable/10.1 stable/10.0 |
✅ Backports have been created
|
|
@Mergifyio rebase |
Currently, peergroup_filter_check() does not check whether exist-map or non-exist-map is configured along with advertise-map. This check is missing only when the peer is part of peergroup and having the exist/non-exist-map. So the 'show run' does not show the configured exist/non-exist-map as expected. This new check is needed because, unlike other filter type the adv-map can have exist/non-exist-map additionally and we don't store this in the filter_override but store only the adv-map. So, a specific check is required to account the exist/non-exist-map while printing the adv-map config. Fixing the same by adding a check. Signed-off-by: Krishnasamy <[email protected]>
✅ Branch has been successfully rebased |
ton31337
force-pushed
the
krishna-samy/exist-map
branch
from
aff1639 to
aa012d8
Compare
done |
done |
|
Please fix frrbot (python styling) and good to merge. |
krishna-samy
force-pushed
the
krishna-samy/exist-map
branch
from
25a2c43 to
5b7a0a1
Compare
Signed-off-by: Krishnasamy <[email protected]>
krishna-samy
force-pushed
the
krishna-samy/exist-map
branch
from
5b7a0a1 to
f15cb73
Compare
done. |
ton31337
approved these changes
May 20, 2025
This was referenced May 20, 2025
This was referenced May 20, 2025
donaldsharp
added a commit
that referenced
this pull request
May 22, 2025
bgpd: fix to show exist/non-exist-map in 'show run' properly (backport #18828)
donaldsharp
added a commit
that referenced
this pull request
May 22, 2025
bgpd: fix to show exist/non-exist-map in 'show run' properly (backport #18828)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, peergroup_filter_check() does not check whether exist-map or non-exist-map is configured along with advertise-map. This check is missing only when the peer is part of peergroup and having the exist/non-exist-map. So the 'show run' does not show the configured exist/non-exist-map as expected.
This new check is needed because, unlike other filter type the adv-map can have exist/non-exist-map additionally and we don't store this in the filter_override but store only the adv-map. So, a specific check is required to account the exist/non-exist-map while printing the adv-map config. Fixing the same by adding a check.