fix(runtime): resync image-metadata.mjs after #68 - #347
Merged
Conversation
#68 added readRawDimensions() directly to the generated macos/scripts/image-metadata.mjs without updating the canonical runtime/image-metadata.mjs source, so tools/sync-runtime-assets.mjs --check fails on main and windows/scripts/image-metadata.mjs never picked up the new export at all. Port the same split to the source and regenerate both platform outputs.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#68(merged) addedreadRawDimensions()directly to the generatedmacos/scripts/image-metadata.mjswithout updating the canonicalruntime/image-metadata.mjssource thattools/sync-runtime-assets.mjsgenerates it from. Result:node tools/sync-runtime-assets.mjs --checkfails on currentmain(out-of-date=macos/scripts/image-metadata.mjs), andmacos/tests/run-tests.shexits 1.windows/scripts/image-metadata.mjsnever picked upreadRawDimensionsat all — cross-platform drift.Fix
Port the same
readRawDimensionssplit intoruntime/image-metadata.mjs(the actual source of truth) and regenerate both platform outputs vianode tools/sync-runtime-assets.mjs.Verification
node tools/sync-runtime-assets.mjs --check→ exit 0 (clean)NODE=$(which node) bash macos/tests/run-tests.sh→ full suite passes (previously failed at the image-metadata drift check)