Skip to content

Conversation

@zachaysan
Copy link
Contributor

@zachaysan zachaysan commented Oct 4, 2024

Change

Pulling over different concerns into the commons repository to support the change request for segments work. Impacts these two PRs.

@zachaysan zachaysan requested a review from khvn26 October 8, 2024 14:32
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this but can't help but notice missing test coverage.

@zachaysan
Copy link
Contributor Author

Approving this but can't help but notice missing test coverage.

We have test coverage from the other units that import these, which Matt and I think is fine.

@zachaysan zachaysan merged commit 27fbd8b into main Oct 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants