-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Separate task processor database #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
81192cf
to
0607086
Compare
0607086
to
32cba38
Compare
880cd2c
to
ec6c2e5
Compare
d94ef9a
to
9152ba6
Compare
9152ba6
to
09ec777
Compare
3377619
to
521c7c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, apart from minor questions/suggestions.
This reverts commit afecfcc.
be9a646
to
6bb822c
Compare
1050290
to
3fef273
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 93.70% 94.17% +0.46%
==========================================
Files 71 74 +3
Lines 2003 2147 +144
==========================================
+ Hits 1877 2022 +145
+ Misses 126 125 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4cf0a25
to
0131747
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, apart from one unresolved thread and one nit
ddb2a3d
to
49da185
Compare
Ref: Flagsmith/flagsmith#5136
Teaches task processor to speak multi database, assuming
"task_processor"
is the Django database to be optionally introduced.Also allows for consuming tasks from both databases
default
andtask_processor
, as a means to exhaust remaining tasks fromdefault
when opting in totask_processor
. Also optional.Please read documentation introduced in the pull request to core.