Skip to content

feat: Separate task processor database #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 19, 2025

Conversation

emyller
Copy link
Contributor

@emyller emyller commented May 5, 2025

Ref: Flagsmith/flagsmith#5136

Teaches task processor to speak multi database, assuming "task_processor" is the Django database to be optionally introduced.

Also allows for consuming tasks from both databases default and task_processor, as a means to exhaust remaining tasks from default when opting in to task_processor. Also optional.

Please read documentation introduced in the pull request to core.

@emyller emyller self-assigned this May 5, 2025
@emyller emyller force-pushed the feat/separate-task-processor-database branch from 81192cf to 0607086 Compare May 8, 2025 00:26
@emyller emyller force-pushed the feat/separate-task-processor-database branch from 0607086 to 32cba38 Compare May 8, 2025 22:48
@emyller emyller force-pushed the feat/separate-task-processor-database branch from 880cd2c to ec6c2e5 Compare May 10, 2025 00:36
@emyller emyller force-pushed the feat/separate-task-processor-database branch from d94ef9a to 9152ba6 Compare May 12, 2025 18:19
@emyller emyller force-pushed the feat/separate-task-processor-database branch from 9152ba6 to 09ec777 Compare May 12, 2025 21:14
Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@emyller emyller marked this pull request as ready for review May 13, 2025 14:22
@emyller emyller requested a review from a team as a code owner May 13, 2025 14:22
@emyller emyller requested review from gagantrivedi and removed request for a team May 13, 2025 14:22
Copy link
Member

@gagantrivedi gagantrivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from minor questions/suggestions.

@emyller emyller force-pushed the feat/separate-task-processor-database branch from be9a646 to 6bb822c Compare May 15, 2025 20:40
@emyller emyller force-pushed the feat/separate-task-processor-database branch from 1050290 to 3fef273 Compare May 15, 2025 20:43
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.17%. Comparing base (1cac2c9) to head (49da185).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   93.70%   94.17%   +0.46%     
==========================================
  Files          71       74       +3     
  Lines        2003     2147     +144     
==========================================
+ Hits         1877     2022     +145     
+ Misses        126      125       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@emyller emyller force-pushed the feat/separate-task-processor-database branch from 4cf0a25 to 0131747 Compare May 16, 2025 18:40
Copy link
Member

@gagantrivedi gagantrivedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from one unresolved thread and one nit

@emyller emyller force-pushed the feat/separate-task-processor-database branch from ddb2a3d to 49da185 Compare May 19, 2025 20:23
@emyller emyller merged commit fd2373e into main May 19, 2025
4 checks passed
@emyller emyller deleted the feat/separate-task-processor-database branch May 19, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants