ci: fix testing workflow #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…necessary changes
…down to necessary changes" This reverts commit 9150ac3.
matthewelwell
changed the title
tiagoapolo
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, so this PR was born out of issues seen primarily in #130.
I'm still not entirely sure why the workflows suddenly stopped working, but I suspect it has something to do with an upgrade on the github side which removed .net6.0 from the machines as a default.
This PR does the following:
We should, in the near future, drop support for .net6.0 and major version the client, but I first want to get #130 out of the door and this is a quick win to get that done.