feat: Deprecate constructors with >1 parameter and IFlagsmithConfig interface. Add EnableLocalEvaluation and EnvironmentRefreshInterval properties #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolodato
changed the title
rolodato
changed the title
rolodato
force-pushed
the
feat/local-evaluation-name
branch
from
3dc1a99 to
161f3f2
Compare
There was a problem hiding this comment.
I've left a few comments but overall looks good. I'm not sure if this comment from the PR description is still valid though as it looks like there have been more changes to client / interface since then?
Validated this does not break existing code by running the existing test suite without changes: 0b41d2b
I added the previous tests as they're currently in |
matthewelwell
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135.
Validated this does not break existing code by running the existing test suite without changes: 0b41d2b