Skip to content

feat: Deprecate constructors with >1 parameter and IFlagsmithConfig interface. Add EnableLocalEvaluation and EnvironmentRefreshInterval properties #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 4, 2025
Merged

feat: Deprecate constructors with >1 parameter and IFlagsmithConfig interface. Add EnableLocalEvaluation and EnvironmentRefreshInterval properties #136

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
060009d
WIP
rolodato Jan 21, 2025
e9bc93f
Fix tests
rolodato Feb 26, 2025
0b41d2b
dotnet format
rolodato Feb 26, 2025
0d884f6
Update tests to not use deprecated constructors, fix warnings
rolodato Feb 26, 2025
ce4aa95
Don't inherit from IFlagsmithConfiguration
rolodato Feb 26, 2025
a21669c
Better defaults
rolodato Feb 26, 2025
b841d3a
Deprecate IsValid
rolodato Feb 26, 2025
e3635b8
Use intervals instead of seconds+maths
rolodato Feb 28, 2025
161f3f2
Replace parameterless constructor with property defaults
rolodato Feb 28, 2025
1753943
Re-add tests that use deprecated features from main
rolodato Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
324 changes: 231 additions & 93 deletions Flagsmith.Client.Test/FlagsmithTest.cs
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions Flagsmith.Client.Test/PollingManagerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public void TestPollingManagerCallsUpdateEnvironmentOnStart()
isCalled = true;
return Task.CompletedTask;
};
var x = new PollingManager(callback);
var x = new PollingManager(callback, TimeSpan.Zero);
_ = x.StartPoll();
Assert.True(isCalled);
x.StopPoll();
Expand All @@ -32,7 +32,7 @@ public async Task TestPollingManagerCallsUpdateEnvironmentOnEachRefresh()
calledCount += 1;
return Task.CompletedTask;
};
var x = new PollingManager(callback, 1);
var x = new PollingManager(callback, TimeSpan.FromSeconds(1));
_ = x.StartPoll();
await Task.Delay(3000);
Assert.True(calledCount >= 3); // check pollingmanager polls atlease 3 times.
Expand Down
Loading
Loading