Skip to content

fix: Analytics update is blocking #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025
Merged

fix: Analytics update is blocking #156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd26c99
fix: Analytics update is blocking
khvn26 May 16, 2025
4f423d2
;
khvn26 May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Flagsmith.FlagsmithClient/Flags.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,17 @@ public Flags(List<IFlag> flags, AnalyticsProcessor analyticsProcessor, Func<stri
}
public async Task<string> GetFeatureValue(string featureName) => (await GetFlag(featureName)).Value;
public async Task<bool> IsFeatureEnabled(string featureName) => (await GetFlag(featureName)).Enabled;
public async Task<IFlag> GetFlag(string featureName)
public Task<IFlag> GetFlag(string featureName)
{
var flag = _Flags?.FirstOrDefault(f => f.GetFeatureName().Equals(featureName));
if (flag == null)
{
return _DefaultFlagHandler?.Invoke(featureName) ?? throw new FlagsmithClientError("Feature does not exist: " + featureName);
return Task.FromResult(_DefaultFlagHandler?.Invoke(featureName) ?? throw new FlagsmithClientError("Feature does not exist: " + featureName));

}
if (_AnalyticsProcessor != null)
await _AnalyticsProcessor.TrackFeature(flag.GetFeatureName()).ConfigureAwait(false);
return flag;
_ = _AnalyticsProcessor.TrackFeature(flag.GetFeatureName());
return Task.FromResult(flag);
}
public List<IFlag> AllFlags() => _Flags;
private static IFlag FromFeatureStateModel(FeatureStateModel featureStateModel, string identityId = null) =>
Expand Down
Loading