fix: Analytics update is blocking #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the Analytics update is blocking the main execution flow. The key changes include converting the async GetFlag method to a synchronous returning Task wrapper and updating the analytics tracking call to execute without awaiting.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the implementation of the GetFlag method to address blocking behavior in the analytics tracking mechanism. The changes convert the method from async-await to a synchronous signature using Task.FromResult, and modify the way analytics events are triggered.
- Converted GetFlag to non-async, returning a task via Task.FromResult.
- Changed analytics tracking to a fire-and-forget call.
Comments suppressed due to low confidence (1)
Flagsmith.FlagsmithClient/Flags.cs:23
- Changing from an async method to a synchronous signature using Task.FromResult alters exception propagation; verify that this change does not lead to unhandled errors, especially when using throw expressions within Task.FromResult.
public Task<IFlag> GetFlag(string featureName)
matthewelwell
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142.