Skip to content

Conversation

@matthewelwell
Copy link
Contributor

Adds defaults to attributes in the OrganisationModel and ProjectModel classes which have defaults in the django ORM models.

Adding these should simplify interfaces when creating custom offline handlers for example.

@matthewelwell matthewelwell requested review from a team and khvn26 and removed request for a team June 23, 2025 18:57
@github-actions
Copy link

github-actions bot commented Jun 23, 2025

File Coverage
All files 100%

Minimum allowed coverage is 100%

Generated by 🐒 cobertura-action against 30441d9

Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we got an OfflineHandler implementation example somewhere? Curious to see the impact of this (and whether we can make further improvements).

@matthewelwell
Copy link
Contributor Author

matthewelwell commented Jun 25, 2025

Have we got an OfflineHandler implementation example somewhere? Curious to see the impact of this (and whether we can make further improvements).

@khvn26 the only one that I'm using as a reference is the one in the PR here (which wasn't really ready for review yet, but I appreciate the feedback!)

I think these changes are useful, if incomplete, regardless of the comments on the other PR.

@matthewelwell matthewelwell merged commit d909c2f into main Jun 25, 2025
6 checks passed
@matthewelwell matthewelwell deleted the chore/add-sane-model-defaults branch June 25, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants