Skip to content

chore: add sane model defaults to OrganisationModel and ProjectModel #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2025
Merged

chore: add sane model defaults to OrganisationModel and ProjectModel #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2755038
Add sane model defaults to OrganisationModel and ProjectModel
matthewelwell Jun 23, 2025
04b40cd
Test against 3.11 and 3.12
matthewelwell Jun 23, 2025
30441d9
Merge branch 'refs/heads/main' into chore/add-sane-model-defaults
matthewelwell Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
max-parallel: 4
matrix:
python-version: ['3.8', '3.9', '3.10']
python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']

steps:
- name: Cloning repo
Expand Down
6 changes: 3 additions & 3 deletions flag_engine/organisations/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
class OrganisationModel(BaseModel):
id: int
name: str
feature_analytics: bool
stop_serving_flags: bool
persist_trait_data: bool
feature_analytics: bool = False
stop_serving_flags: bool = False
persist_trait_data: bool = True

@property
def unique_slug(self) -> str:
Expand Down
2 changes: 1 addition & 1 deletion flag_engine/projects/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class ProjectModel(BaseModel):
id: int
name: str
organisation: OrganisationModel
hide_disabled_flags: bool
hide_disabled_flags: bool = False
segments: typing.List[SegmentModel] = Field(default_factory=list)
enable_realtime_updates: bool = False
server_key_only_feature_ids: typing.List[int] = Field(default_factory=list)