Remove uses of any in models.ts
#180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
This is great, thanks very much for the contribution @phiggins ! Apologies for the delayed review.
|
This is now released in v6.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋,
I've recently started using this library at work and was surprised to see the return type of
getFeatureValuewasany. I replaced that with a new type that represents the type of thevaluefield ofBaseFlag, and replaced a few more uses ofanyin the file where there were possible replacements. The only uses ofanyleft are for the incoming data retrieved as json which would be more involved to fix.