Skip to content

Remove uses of any in models.ts #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

Remove uses of any in models.ts #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions sdk/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,24 +1,22 @@
import { FeatureStateModel } from '../flagsmith-engine/features/models.js';
import { AnalyticsProcessor } from './analytics.js';

type FlagValue = string | number | boolean | undefined;

export class BaseFlag {
enabled: boolean;
value: string | number | boolean | undefined;
value: FlagValue;
isDefault: boolean;

constructor(
value: string | number | boolean | undefined,
enabled: boolean,
isDefault: boolean
) {
constructor(value: FlagValue, enabled: boolean, isDefault: boolean) {
this.value = value;
this.enabled = enabled;
this.isDefault = isDefault;
}
}

export class DefaultFlag extends BaseFlag {
constructor(value: string | number | boolean | undefined, enabled: boolean) {
constructor(value: FlagValue, enabled: boolean) {
super(value, enabled, true);
}
}
Expand All @@ -28,7 +26,7 @@ export class Flag extends BaseFlag {
featureName: string;

constructor(params: {
value: string | number | boolean | undefined;
value: FlagValue;
enabled: boolean;
isDefault?: boolean;
featureId: number;
Expand Down Expand Up @@ -82,7 +80,7 @@ export class Flags {
defaultFlagHandler?: (f: string) => DefaultFlag;
identityID?: string | number;
}): Flags {
const flags: { [key: string]: any } = {};
const flags: { [key: string]: Flag } = {};
for (const fs of data.featureStates) {
flags[fs.feature.name] = Flag.fromFeatureStateModel(fs, data.identityID);
}
Expand All @@ -98,7 +96,7 @@ export class Flags {
analyticsProcessor?: AnalyticsProcessor;
defaultFlagHandler?: (v: string) => DefaultFlag;
}): Flags {
const flags: { [key: string]: any } = {};
const flags: { [key: string]: Flag } = {};

for (const flagData of data.apiFlags) {
flags[flagData['feature']['name']] = Flag.fromAPIFlag(flagData);
Expand All @@ -124,7 +122,6 @@ export class Flags {
}

return { enabled: false, isDefault: true, value: undefined };

}

if (this.analyticsProcessor && flag.featureId) {
Expand All @@ -134,7 +131,7 @@ export class Flags {
return flag;
}

getFeatureValue(featureName: string): any {
getFeatureValue(featureName: string): FlagValue {
return this.getFlag(featureName).value;
}

Expand Down