Skip to content

Conversation

hardillb
Copy link
Contributor

part of FlowFuse/flowfuse#5951

Description

Adds Team Broker support to MQTT Schema agent

Related Issue(s)

FlowFuse/flowfuse#5951

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb self-assigned this Sep 10, 2025
@hardillb hardillb requested a review from knolleary September 16, 2025 12:25
@hardillb hardillb marked this pull request as ready for review September 16, 2025 12:25
Copy link
Member

@knolleary knolleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst this driver is mostly for local testing as this is a license feature which localfs isn't typically used, I do think there are some lifecycle handling challenges with the agent - which could extend back to the existing 3rd party agent support as well.

My concern is around 'reattaching' to the process after a forge app restart - and whether you can end up with multiple agents running.

Am going to approve to help move things forward, but I do think this needs looking at.

@hardillb
Copy link
Contributor Author

hardillb commented Sep 17, 2025

I have a fix that ensures the agent shuts down with the forge app and is restarted (and does the same for the Nod-RED instances).

I just need to work out if the restart should be with the full 24hrs or reduced by elapsed time.

This ensures they exit with the forge app and are restarted when
it comes back up
@hardillb hardillb merged commit ac8fbdb into main Sep 22, 2025
3 checks passed
@hardillb hardillb deleted the team-broker-schema branch September 22, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants