-
Notifications
You must be signed in to change notification settings - Fork 74
Team broker schema agent #6003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Team broker schema agent #6003
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6003 +/- ##
==========================================
- Coverage 76.76% 76.75% -0.01%
==========================================
Files 376 378 +2
Lines 18869 18967 +98
Branches 4492 4516 +24
==========================================
+ Hits 14485 14559 +74
- Misses 4384 4408 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with localfs and all working. My main feedback is on the UX side.
There is an inconsistency between the team and 3rd party broker UX now that I think should be aligned.
Team broker has a button to start schema capture. Once clicked, there's no feedback (other than the button is now disabled) - and no way to stop the schema capture.

3rd Party broker already has a toggle button for the same concept:

I think this needs to be aligned.
![]() Okay, here me out... we have all three toggles, with disabled states as per this screenshot for those not interactive in the different combinations. The important factor is a tooltip to explain why it's disabled. Emphasising here, that the Live data is gathered 24/7 for third-party brokers). For the Team Broker, I don't think we need the top-level toggle, and only the two at the lower level, however, do should have the So, to clarify:
Whilst the left-toggle is always disabled, I feel it still necessary to emphasise that's it's live and doing something. @hardillb let me know if you want me to dev this up. |
@joepavitt I think I follow what your saying and agree, but if you could start on the front end and shout if there any backend changes needed |
@hardillb I've updated the UI, I've not implemented the turning off the agent for Team Broker, but do feel free to if you think it'd be useful. |
I've fixed the lint and removed the alert because it was triggering if you navigated from a disabled broker to the already running Team Broker. I'm going to leave being able to turn team broker collection off manually for now But it looks a lot more consistent across the 2 modes now. |
Tested locally with driver-localfs. |
@hardillb I have approved the core pr, driver-localfs and the agent. Due to their interdependencies when it comes to deploying to prod, will let you merge in the appropriate order. |
@knolleary Thanks, will get with Steve today to wrap up the driver-docker side and the it can all be merged |
closes #5951
Description
This PR includes a DB migration - ensure it is properly named before merging
Adds support for Team Broker to MQTT Schema capture.
Depends on
And on other container drivers:
Related Issue(s)
#5951
Checklist
flowforge.yml
?FlowFuse/helm
to update ConfigMap TemplateFlowFuse/CloudProject
to update values for Staging/ProductionLabels
area:migration
label