Skip to content

cleanup premake links#2815

Merged
mercury233 merged 1 commit into
Fluorohydride:masterfrom
mercury233:patch-clean-links
May 31, 2025
Merged

cleanup premake links#2815
mercury233 merged 1 commit into
Fluorohydride:masterfrom
mercury233:patch-clean-links

Conversation

@mercury233

Copy link
Copy Markdown
Collaborator
  • The links directive in Premake applies to a project, not to the workspace.
  • Specifying links for a static library has no actual effect.
  • On Windows, libraries such as opengl32 and imm32 are already brought in via #pragma comment(lib, ...).
  • On Windows, system libraries like kernel32 and user32 are linked automatically by MSVC.
  • Starting with glibc 2.34, there is no longer any need to link against libdl or libpthread explicitly.
  • libz (zlib) is bundled in the source trees of Irrlicht and FreeType, so it does not need to be linked separately.
  • libm (math.h) is a dependency of libstdc++, so it also does not need to be linked explicitly.

@mercury233 mercury233 merged commit 38e198d into Fluorohydride:master May 31, 2025
8 checks passed
@mercury233 mercury233 deleted the patch-clean-links branch May 31, 2025 22:26
@purerosefallen

Copy link
Copy Markdown
Collaborator
          irrlicht.lib(CIrrDeviceWin32.obj) : error LNK2001: �޷��������ⲿ���� ImmNotifyIME [C:\images\builds\nvYJyXaZ\0\nanahira\ygopro\build\YGOPro.vcxproj]
          irrlicht.lib(CIrrDeviceWin32.obj) : error LNK2001: �޷��������ⲿ���� ImmAssociateContextEx [C:\images\builds\nvYJyXaZ\0\nanahira\ygopro\build\YGOPro.vcxproj]
          irrlicht.lib(CIrrDeviceWin32.obj) : error LNK2001: �޷��������ⲿ���� ImmSetCompositionWindow [C:\images\builds\nvYJyXaZ\0\nanahira\ygopro\build\YGOPro.vcxproj]
          irrlicht.lib(CIrrDeviceWin32.obj) : error LNK2001: �޷��������ⲿ���� ImmReleaseContext [C:\images\builds\nvYJyXaZ\0\nanahira\ygopro\build\YGOPro.vcxproj]
          irrlicht.lib(CIrrDeviceWin32.obj) : error LNK2001: �޷��������ⲿ���� ImmGetContext [C:\images\builds\nvYJyXaZ\0\nanahira\ygopro\build\YGOPro.vcxproj]

@purerosefallen

Copy link
Copy Markdown
Collaborator

mercury233/irrlicht@456556d

fine after this.
But next time plz refer it in PR if depending on other repo commits, just as how ocgcore did.

This was referenced Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants