patch miniaudio#2833
Conversation
|
DON'T use patch. |
|
You should define the |
Both my irrlicht fork and the original irrlicht 1.9 don't have And miniaudio is using |
In my case the call actually setting up COM is OleInitialize, which sets it to apartment threaded, (in the file you pointed out com is de initialized after the function si executed). My guess is that the ime handling is internally initializing COM with that specific threading model beforehand. |
|
#2840 |
|
I don't think so. Fork repo may cause problem such as #2815 (comment) |
We can avoid by telling the related repo commit / PR in our PR description. However, patch is even harder to maintain, and sometimes the patch may fail with no reasons. |
Problem:
Crash when using wetype IME (微信输入法), Use-After-Free when using sogou IME (搜狗输入法)
Solution:
Apply mackron/miniaudio#968 before miniaudio release a new version.
Another solution: define
MA_NO_WASAPIas workaround