Skip to content

use patched miniaudio#2840

Merged
mercury233 merged 1 commit into
Fluorohydride:masterfrom
mercury233:patch-patch-miniaudio-2
Jun 19, 2025
Merged

use patched miniaudio#2840
mercury233 merged 1 commit into
Fluorohydride:masterfrom
mercury233:patch-patch-miniaudio-2

Conversation

@mercury233

Copy link
Copy Markdown
Collaborator

alternate to #2833

https://github.com/mercury233/miniaudio : Applied that patch to the codes in miniaudio_split, when the dev branch of upstream didn't.

@purerosefallen purerosefallen mentioned this pull request Jun 14, 2025
@purerosefallen

Copy link
Copy Markdown
Collaborator

just for ref, in mycard:

@mercury233

Copy link
Copy Markdown
Collaborator Author

and another https://code.moenext.com/mycard/miniaudio-new with weird changes and not sync with any upstream?

@purerosefallen

Copy link
Copy Markdown
Collaborator

and another https://code.moenext.com/mycard/miniaudio-new with weird changes and not sync with any upstream?

***-new exists because there was an outdated repo. Ages before there were irrlicht, irrlicht-mac so the new repo called irrlicht-new

Now it can be called miniaudio without -new because first one is good enough.

@mercury233

Copy link
Copy Markdown
Collaborator Author

Now it can be called miniaudio without -new because first one is good enough.

One day it will be not good enough if you don't sync with upstream.

@purerosefallen

purerosefallen commented Jun 14, 2025

Copy link
Copy Markdown
Collaborator

Now it can be called miniaudio without -new because first one is good enough.

One day it will be not good enough if you don't sync with upstream.

syncing is done when a pre tag submitted, or during release.

irrlicht had some historic reasons, such as multiple versions, build method change. we believe the same thing would not occur in miniaudio if properly maintained

btw it's a bit OT to talk about mycard infra maintenance

@purerosefallen

Copy link
Copy Markdown
Collaborator

could we use this one now?

@mercury233

Copy link
Copy Markdown
Collaborator Author

could we use this one now?

it is up to you

@mercury233 mercury233 merged commit 5cbf953 into Fluorohydride:master Jun 19, 2025
8 checks passed
@mercury233 mercury233 deleted the patch-patch-miniaudio-2 branch June 19, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants