fix new replay crash#2846
Merged
Merged
Conversation
Collaborator
|
Maybe we should use fseek |
Collaborator
Author
then you make one |
Collaborator
Author
|
https://chatgpt.com/share/6853cb2e-f788-800e-b8c8-09d554f01b18 some changes may required |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adjust the replay loading logic to fully read the YRP2 header and prevent crashes due to incomplete data.
- Expand the
freadcall to cover the remainder of the header after the base ID - Use pointer arithmetic to calculate the offset and size for reading the rest of
pheader
salix5
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.