Skip to content

fix new replay crash #2846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mercury233 merged 5 commits into from
Jun 19, 2025
Merged

fix new replay crash #2846

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a982883
fix new replay crash
purerosefallen Jun 19, 2025
95c3d46
Update replay.cpp
purerosefallen Jun 19, 2025
26ed93c
format
purerosefallen Jun 19, 2025
633adab
change again
purerosefallen Jun 19, 2025
65671fd
reinterpret_cast
salix5 Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gframe/replay.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ bool Replay::OpenReplay(const wchar_t* name) {
std::fclose(rfp);
return false;
}
if (pheader.base.id == REPLAY_ID_YRP2 && std::fread(&pheader.seed_sequence, sizeof pheader.seed_sequence, 1, rfp) < 1) {
if (pheader.base.id == REPLAY_ID_YRP2 && std::fread((uint8_t*)(&pheader) + sizeof pheader.base, sizeof pheader - sizeof pheader.base, 1, rfp) < 1) {
Comment thread
salix5 marked this conversation as resolved.
Outdated
std::fclose(rfp);
return false;
}
Expand Down