verify default_lflist after loading#3136
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves default_lflist validation to the point where the LF list has just been loaded, ensuring the config index is clamped before UI components and the deck builder consume it (follow-up/fix for PR #3126).
Changes:
- Validate/clamp
gameConf.default_lflistimmediately afterdeckManager.LoadLFList()inGame::Initialize(). - Remove redundant validation logic from
DeckBuilder::Initialize()and directly index into_lfListusing the (now prevalidated) config value.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| gframe/game.cpp | Validates default_lflist after LF list load so downstream UI/deck builder indexing is safe. |
| gframe/deck_con.cpp | Simplifies deck builder initialization by relying on the centralized validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+104
to
+105
| if(gameConf.default_lflist >= (int)deckManager._lfList.size() || gameConf.default_lflist < 0) | ||
| gameConf.default_lflist = 0; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #3126