Make the composition workflow notebook more robust#316
Closed
Conversation
Collaborator
Author
|
Okay, I found the roadblock here preventing docs from passing. We need this: |
Closed
Collaborator
Author
|
These changes actually work for me under locally under Julia 1.11. @EssamWisam I know this is failing for now, but could you please take a quick look over the changes, as you were the original author? |
Collaborator
Author
|
Closed in favour of #318 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc generation is failing for me locally because a new release of Julia has broken a notebook that uses an unstable RNG. I've made some changes to make the notebook more robust.
No need for a new release.
This PR will close #314.