Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #318 +/- ##
==========================================
+ Coverage 92.67% 94.85% +2.17%
==========================================
Files 14 15 +1
Lines 519 525 +6
==========================================
+ Hits 481 498 +17
+ Misses 38 27 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks great to me. I remember experiencing confusion with the |
There was a problem hiding this comment.
Is removing this intended?
There was a problem hiding this comment.
Yes, in two cases I have intentionally removed the pre-executed versions of the notebooks. Literate.jl successfully creates executables for the others but fails on these (and this was true in the past for me). Previously, I would just execute by loading into jupyter but, as is typical in my experience of using Jupyter notebooks with Julia, there's some voodoo magic I have to figure out to get the latest julia kernel to load properly and I decided to give up this time around, because I don't like to maintain fragile workflows like this.
There was a problem hiding this comment.
Here also we have the unexecuted notebook only. I don't mind not having the other one though in both instances.
|
Thank you @EssamWisam for the review! |
Replaces #316. Closes #314.
This PR is chiefly about making doc generation more robust across all the examples. There are only small content tweaks.
This PR:
StableRNGto enforce reproducibility across Julia versions. (Some instability around RNG's caused the docs to crash after Julia 1.12 release).