remove the version-based condition on the loading of SVG support stylesheet#264
Merged
mlwilkerson merged 2 commits intomainfrom Sep 24, 2025
Merged
remove the version-based condition on the loading of SVG support stylesheet#264mlwilkerson merged 2 commits intomainfrom
mlwilkerson merged 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #263
This PR reverts a prior change to use
svg.csswhen Font Awesome 7 is active. It takes us back to always usingsvg-with-js.css, which includes the animations CSS.Upside: everything that's needed is available in
svg-with-js.cssDownside: more than is needed is included in
svg-with-js.css. It's about twice the size ofsvg.css. And some of that will be loaded twice, because the kit loader will load some of that same content, whether it's a webfont kit or SVG kit.However, for now, it's better to load more than necessary and have all of the feature support, than to load
svg.cssto minimize the number of bytes loaded and break animations.