Skip to content

remove the version-based condition on the loading of SVG support stylesheet #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mlwilkerson merged 2 commits into from
Sep 24, 2025
Merged

remove the version-based condition on the loading of SVG support stylesheet #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1422eba
remove the version-based condition on the loading of svg.css vs.
mlwilkerson Sep 24, 2025
5c6763f
remove unused $version param
mlwilkerson Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions includes/class-fontawesome-release-provider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,9 +552,7 @@ public static function get_option() {
* @return FontAwesome_Resource
*/
public function get_svg_styles_resource( $version ) {
$file_basename = ( is_string( $version ) && strlen( $version ) > 0 && '7' === $version[0] )
? 'svg'
: 'svg-with-js';
$file_basename = 'svg-with-js';

$cdn_url_template = null;

Expand Down
6 changes: 2 additions & 4 deletions includes/class-fontawesome-svg-styles-manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,8 @@ public static function selfhost_asset_subdir( $version ) {
* @ignore
* @internal
*/
public static function selfhost_asset_filename( $version ) {
return ( is_string( $version ) && strlen( $version ) > 0 && '7' === $version[0] )
? 'svg.css'
: 'svg-with-js.css';
public static function selfhost_asset_filename() {
return 'svg-with-js.css';
}

/**
Expand Down
Loading