Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change challenge where-art-though name to match English fcc one #352

Merged
merged 1 commit into from
Aug 6, 2017

Conversation

wudifeixue
Copy link
Contributor

In this PR:

Fix issue #232

Do note I am a bit afraid that this change would break the whole project.
But this is all the sources I can find for the changes I have to make.

@S1ngS1ng
Copy link
Contributor

S1ngS1ng commented Aug 1, 2017

@wudifeixue Did you run it on local server? I am wondering if it covers the Map panel.

@wudifeixue
Copy link
Contributor Author

First off I just did a test on this and it works great.

image

Well, I run node seed and everything works great.
Then I can start the project with gulp too without a problem. (I already used mongod)

Here is the problem

  • I can not open these two locally.
    image

I also tried to npm test this, then it did not pass.

  Failed Tests: There was 1 failure

    Friendly Date Ranges


      ✖ TypeError: assert.isNotArray is not a function


  total:     729
  passing:   728
  failing:   1
  duration:  7s



npm ERR! Darwin 16.7.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "test-challenges"
npm ERR! node v6.9.5
npm ERR! npm  v4.2.0
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] test-challenges: `babel-node seed/test-challenges.js | tap-spec`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] test-challenges script 'babel-node seed/test-challenges.js | tap-spec'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the freecodecamp.cn package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     babel-node seed/test-challenges.js | tap-spec
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs freecodecamp.cn
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls freecodecamp.cn
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/Curtis/.npm/_logs/2017-08-01T20_30_00_562Z-debug.log
npm ERR! Test failed.  See above for more details.

2017-08-01T20_30_00_562Z-debug.log

After upgrade node and npm as well I experienced the same problem, it seems like PR #248 with assert.isNotArray is causing some trouble.

@S1ngS1ng S1ngS1ng self-assigned this Aug 2, 2017
@S1ngS1ng
Copy link
Contributor

S1ngS1ng commented Aug 2, 2017

@wudifeixue Will take a look today.

@S1ngS1ng S1ngS1ng mentioned this pull request Aug 3, 2017
@wudifeixue
Copy link
Contributor Author

This one should be good too now since test is fixed, though how come I can't open chat or course list locally?

@S1ngS1ng
Copy link
Contributor

S1ngS1ng commented Aug 3, 2017

@wudifeixue Not sure 🤦‍♂️ . Are these rendered from server side? I guess...

@wudifeixue
Copy link
Contributor Author

Have you tested them out locally?

@S1ngS1ng
Copy link
Contributor

S1ngS1ng commented Aug 6, 2017

@wudifeixue
Yep. Works fine on my side. Thanks!
image

Copy link
Contributor

@S1ngS1ng S1ngS1ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@S1ngS1ng S1ngS1ng merged commit e6d7362 into FreeCodeCampChina:dev Aug 6, 2017
@wudifeixue wudifeixue deleted the wherefore-art-thou branch August 25, 2017 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants