Hide member only videos (Local API) #7208

PikachuEXE · 2025-04-15T01:29:57Z

Pull Request Type

Bugfix
Feature Implementation
Documentation
Other

Related issue

Related to #6425 but IV API not supported yet so won't close it

Description

There are member only videos in subscription/channel video list
This PR hides them
IV API has no such attribute so can't implement for it

Screenshots

Badge version screenshot (previous implementation, now for showing example member only videos)

Testing

A. Member only

Visit channel(s) with member only videos (e.g. https://www.youtube.com/channel/UCXuqSBlHAE6Xw-yeJA0Tunw
Ensure no member only videos
Search member only videos in channel
Ensure no member only videos
Subscribe (to a new profile if needed, probably easier) the channel and refresh feed in subscription page
Ensure no member only videos
Search for hash tag of member only videos (I got no example for this
Ensure no member only videos

B. Member first
Same as above but it might be time limited (you can only test during specific time period each day, e.g. https://www.youtube.com/channel/UCy8E4XShrcph5WWLg05zETQ only has 1 member first video per day several hours before 18:00 UTC+8/10:00 UTC)

Desktop

OS:
OS Version:
FreeTube version:

Additional context

absidue · 2025-04-15T05:26:50Z

My understanding was that we were going to always hide them from the channel and subscription pages, by skipping them during the parsing, like we do with the members-only section on the channel home tab, without a setting or labelling them. There is no point showing videos that you have no way of watching in FreeTube (you require a Google account that is paying a subscription to the channel in question).

So that begs the question, is this just a temporary PR to learn how to identify members-only videos and you'll revert the changes and implement the skipping in a follow up or have you decided to change plans?

PikachuEXE · 2025-04-15T05:43:13Z

I think it depends on the channel
I see some channels just posting members only videos as an early release to supporters.
For those I am not sure if users want to use bookmark them early or whatever.
Also IV API is not supporting members only property yet so showing a badge can at least be a stop gap solution until IV API also supports it. (i.e. Local API provides more info and we just show it instead of just hiding some videos in local API which might seem a bug

I might just hide them if IV API supports it already

efb4f5ff-1298-471a-8973-3d47447115dc · 2025-04-15T07:48:07Z

The plan is definitely to go back to state FT was in before. Dont show member only content anywhere like explained in #6437

At this point we have many features that are only on Local API that arent available on IV.

I think the route needs to be:

Create PR here to filter on Local API
Create PR on IV side to make filtering available to us

PikachuEXE · 2025-04-16T00:57:56Z

I will wait for #7187 to avoid merge conflict...

PikachuEXE · 2025-04-19T01:09:22Z

Updated to hide member only videos
Don't have example for hash tag view

PikachuEXE · 2025-04-19T07:44:13Z

I got videos with Members first (e.g. https://www.youtube.com/channel/UCy8E4XShrcph5WWLg05zETQ
Hide?

efb4f5ff-1298-471a-8973-3d47447115dc · 2025-04-19T08:09:37Z

Yes, hide it. Nice catch.

How it looks like on YT

Edit: maybe also add it to https://github.com/FreeTubeApp/FreeTube/blob/development/src/renderer/helpers/api/local.js#L911

2nd edit:
From https://support.google.com/youtube/answer/7544492?hl=en

With the members-only to public feature, you can upload content that only your channel members can view for a certain period of time, before access opens up to others. Giving your channel members early access to your content lets them view and engage with your content, before it goes public.

I wonder how it will present it in FT when it becomes available to everyone

PikachuEXE · 2025-04-19T10:06:29Z

I wonder how it will present it in FT when it becomes available to everyone

Just normal video

Also I never see member only/first videos in home tab

absidue · 2025-04-19T12:08:12Z

The channel home tab has a dedicated member's only section and we already skip parsing that entire section (unlike the approach in this PR which parses members-only stuff and then filters it out right at the end), so I'm pretty sure they won't show any other members-only stuff there. The only place I've seen members-only and members-first is on the channel videos tab, which is is also used on the subscriptions page.

efb4f5ff-1298-471a-8973-3d47447115dc · 2025-04-19T19:35:58Z

FYI: PR on IV side iv-org/invidious#5222. Do we need to do something after that PR has merged?

PikachuEXE · 2025-04-19T21:45:41Z

Yes and that PR does not include member first currently, already commented there

PikachuEXE · 2025-04-20T00:47:10Z

Added Member first handling but not tested yet, see updated testing section
Gonna test it myself with custom build

PikachuEXE · 2025-04-20T06:51:40Z

14:50 UTC+8

PikachuEXE · 2025-04-22T06:55:50Z

Updated but the member first channel example doesn't have video a.t.m. so I can't test yet...

* development: (27 commits) [Dev] Bump package version from 0.23.3 to 0.23.4 (FreeTubeApp#7255) Update youtubei.js to latest (FreeTubeApp#7252) Translated using Weblate (Bulgarian) Translated using Weblate (Norwegian Bokmål) Translated using Weblate (Norwegian Bokmål) Translated using Weblate (Danish) Translated using Weblate (Awadhi) Translated using Weblate (Flemish (West)) Translated using Weblate (Afrikaans) Translated using Weblate (Odia) Translated using Weblate (Urdu) Translated using Weblate (Georgian) Translated using Weblate (Azerbaijani) Translated using Weblate (Khmer (Central)) Translated using Weblate (Nepali) Translated using Weblate (Persian) Translated using Weblate (Bengali) Translated using Weblate (Bosnian) Translated using Weblate (Hindi) Translated using Weblate (Korean) ...

PikachuEXE · 2025-04-25T09:24:12Z

Anyone got more example channels with member first videos...?

efb4f5ff-1298-471a-8973-3d47447115dc · 2025-04-25T20:10:02Z

Anyone got more example channels with member first videos...?

Nope couldnt find any but i trust the code

efb4f5ff-1298-471a-8973-3d47447115dc · 2025-04-25T20:23:11Z

Member first channel has a video but i just didnt notice it

PikachuEXE · 2025-04-25T22:54:19Z

I got a bug in video searching in channel, fixing today

absidue · 2025-04-25T23:01:41Z

Probably because you left all the other code in when you added in my suggestion, instead of using it as a replacement as it was intended to be.

* development: Ensure there is at most one power save blocker per open window (FreeTubeApp#7247) Change author name (FreeTubeApp#7216) Migrate ExternalPlayerSettings and SponsorBlockSettings to the composition API (FreeTubeApp#7267) Migrate the FtButton component to the composition API (FreeTubeApp#7266) Cleanup event listener pass-through inline handlers (FreeTubeApp#7268) Feature/add Windows/MacOS Taskbar dock/jumplist task 'New Window' (FreeTubeApp#7049) Translated using Weblate (Hebrew) Translated using Weblate (Norwegian Bokmål) Translated using Weblate (Greek)

PikachuEXE · 2025-04-26T00:30:18Z

Updated, channel searching code was updated to use forEach but I forgot to remove filter after it
Fixed that and also now using reduce instead of declaring an array then forEach
Tested channel searching and haven't tested Hashtag again due to lack of example

Member first re-tested like #7208 (comment)

absidue

Instead of adding extra properties and creating extra arrays all over FreeTube for something that only appears on the channel videos tab (and therefore also on the subscription videos tab), to me at least it makes a lot more sense to do the filtering in the parseLocalChannelVideos function in the src/renderer/helpers/api/local.js

This is still not properly addressed, yes you copied my provided code snippet but didn't actually remove any of the other code. I know you might not care about performance but I do, so I would feel uncomfortable approving and merging something that adds filtering all over FreeTube when it is only needed in one single place. I'm using just that code snippet in my custom build and it is working great. We could always merge this as is and then I could do a follow up PR to clean it up, but that seems wrong too, so it is probably better to get it right in this pull request.

If you think about it the fact that member's only videos only appear on the channel page makes a lot of sense, there it's a "if you liked other videos by this channel you may also like their members only videos" but on the hashtag page, nobody is going to decide to sign up for a paid subscription for a channel they've not watched any videos from, just to watch one members only video.

absidue · 2025-04-26T06:17:38Z

src/renderer/helpers/api/local.js

-      hasCaptions: video.has_captions
+      isMemberOnly: video.badges.some(badge => badge.label === 'Members only'),
+      isMemberFirst: video.badges.some(badge => badge.label === 'Members first'),
+      hasCaptions: video.has_captions,


absidue · 2025-04-26T06:17:49Z

src/renderer/helpers/subscriptions.js

+  videoList = videoList.filter(item => {
+    return !item.isMemberOnly && !item.isMemberFirst
+  })
+


absidue · 2025-04-26T06:18:00Z

src/renderer/views/Channel/Channel.vue

-      latestVideos.value = latestVideos.value.concat(parseLocalChannelVideos(continuation.videos, id.value, channelName.value))
+      latestVideos.value = latestVideos.value.concat(
+        parseLocalChannelVideos(continuation.videos, id.value, channelName.value)
+      )


absidue · 2025-04-26T06:18:45Z

src/renderer/views/Channel/Channel.vue

-    latestLive.value = latestLive.value.concat(parseLocalChannelVideos(continuation.videos, id.value, channelName.value))
+    latestLive.value = latestLive.value.concat(
+      parseLocalChannelVideos(continuation.videos, id.value, channelName.value)
+    )


absidue · 2025-04-26T06:19:28Z

src/renderer/views/Channel/Channel.vue

-      .filter(item => item.type === 'Video' || (!hideChannelPlaylists.value && item.type === 'Playlist'))
-      .map(item => {
+      .reduce((items, item) => {
        if (item.type === 'Video') {
-          return parseLocalListVideo(item)
-        } else {
-          return parseLocalListPlaylist(item, id.value, channelName.value)
+          const video = parseLocalListVideo(item)
+          if (video.isMemberOnly || video.isMemberFirst) { return null }
+
+          items.push(video)
+        } else if (!hideChannelPlaylists.value && item.type === 'Playlist') {
+          items.push(parseLocalListPlaylist(item, id.value, channelName.value))
        }
-      })
+        return items
+      }, [])


absidue · 2025-04-26T06:19:37Z

src/renderer/views/Hashtag/Hashtag.vue

-    videos.value = hashtagData.videos.map((video) => parseLocalListVideo(video))
+    videos.value = hashtagData.videos.reduce((results, video) => {
+      const v = parseLocalListVideo(video)
+      if (v.isMemberOnly || v.isMemberFirst) {
+        results.push(v)
+      }
+      return results
+    }, [])


absidue · 2025-04-26T06:19:50Z

src/renderer/views/Hashtag/Hashtag.vue

-    const newVideos = continuation.videos.map((video) => parseLocalListVideo(video))
+    const newVideos = continuation.videos.reduce((results, video) => {
+      const v = parseLocalListVideo(video)
+      if (v.isMemberOnly || v.isMemberFirst) {
+        results.push(v)
+      }
+      return results
+    }, [])


absidue · 2025-04-26T06:20:01Z

src/renderer/views/Watch/Watch.js

-        forbiddenTitles.some((text) => video.title?.toLowerCase().includes(text.toLowerCase()))
+        forbiddenTitles.some((text) => video.title?.toLowerCase().includes(text.toLowerCase())) ||
+        (video.isMemberOnly || video.isMemberFirst)


PikachuEXE · 2025-04-26T07:46:13Z

Updated, was mostly trying to quick fix the bug I introduce so I can get a custom build that works
And I did not mean that it's all perfect and ready for merge

I know I suck in many ways, performance side included. So I have no problem receiving criticism on implementations and act if necessary.
But I am not comfortable hearing I know you might not care about performance but I do. This kind of speculation should never be said to any current/wanna be contributor.
It's why we have code review.

efb4f5ff-1298-471a-8973-3d47447115dc · 2025-04-26T08:51:52Z

But I am not comfortable hearing I know you might not care about performance but I do. This kind of speculation should never be said to any current/wanna be contributor.
It's why we have code review.

This was indeed not necessary to say. A review can be critical but shouldnt be personal.

I know I suck in many ways

Didnt notice any of them but if you do then you also dont suck in many ways :)

JamesClarke7283 · 2025-04-28T13:16:35Z

Ive been using this PR and its been working well, i haven't been doing performance testing though, just general use.

Do we have a known workflow for performance testing here? if someone has one they use it might be good to share and refer to later. I couldn't find anything on testing in the CONTRIBUTING.md or the wiki.

Using at this commit:
https://github.com/PikachuEXE/FreeTube/commit/fd800c

absidue

I'm really sorry for how I expressed myself, you definitely didn't deserve those harsh words.

PikachuEXE · 2025-04-29T01:27:40Z

@ChunkyProgrammer your power is needed

* development: (35 commits) Hide member only videos (Local API) (FreeTubeApp#7208) Translated using Weblate (Hebrew) Translated using Weblate (Spanish (Mexico)) Bump electron-builder from 26.0.14 to 26.0.15 (FreeTubeApp#7362) Bump mikefarah/yq from 4.45.1 to 4.45.2 (FreeTubeApp#7355) Bump autolinker from 4.1.1 to 4.1.5 (FreeTubeApp#7359) Bump the babel group with 3 updates (FreeTubeApp#7360) Bump npm-run-all2 from 7.0.2 to 8.0.1 (FreeTubeApp#7361) Bump the eslint group with 3 updates (FreeTubeApp#7356) Bump shaka-player from 4.14.9 to 4.14.10 (FreeTubeApp#7357) Translated using Weblate (Icelandic) Translated using Weblate (German) Translated using Weblate (French) Translated using Weblate (Basque) Translated using Weblate (Italian) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (German) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (Estonian) Translated using Weblate (Portuguese (Brazil)) ...

PikachuEXE requested a review from efb4f5ff-1298-471a-8973-3d47447115dc April 15, 2025 01:29

FreeTubeBot enabled auto-merge (squash) April 15, 2025 01:36

github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 15, 2025

absidue added U: Waiting for Response from Author and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Apr 15, 2025

github-actions bot removed the U: Waiting for Response from Author label Apr 15, 2025

PikachuEXE added 2 commits April 19, 2025 08:50

* Show badge for member only videos (Local API)

8ebc265

* Hide members only videos instead

e1533bf

PikachuEXE force-pushed the feature/hide-member-only-videos branch from e449ab8 to e1533bf Compare April 19, 2025 01:05

PikachuEXE changed the title ~~Show badge for member only videos (Local API)~~ Hide member only videos (Local API) Apr 19, 2025

efb4f5ff-1298-471a-8973-3d47447115dc mentioned this pull request Apr 19, 2025

Detect and identify videos restricted to channel members and add settings to exclude them iv-org/invidious#5222

Open

* Handle member first videos

e0c6d22

efb4f5ff-1298-471a-8973-3d47447115dc previously approved these changes Apr 20, 2025

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 20, 2025

PikachuEXE requested review from absidue and ChunkyProgrammer April 20, 2025 13:46

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 20, 2025

PikachuEXE dismissed efb4f5ff-1298-471a-8973-3d47447115dc’s stale review via 4e97456 April 22, 2025 06:32

efb4f5ff-1298-471a-8973-3d47447115dc previously approved these changes Apr 25, 2025

View reviewed changes

PikachuEXE added 2 commits April 26, 2025 08:13

! Fix incorrect code, use #reduce instead

0a9c5f2

PikachuEXE dismissed efb4f5ff-1298-471a-8973-3d47447115dc’s stale review via 0a9c5f2 April 26, 2025 00:27

absidue reviewed Apr 26, 2025

View reviewed changes

* Remove unnecessary changes

fd800c3

efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Apr 27, 2025

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc requested a review from absidue April 27, 2025 13:11

PikachuEXE requested review from absidue and ChunkyProgrammer and removed request for absidue and ChunkyProgrammer April 28, 2025 07:12

absidue approved these changes Apr 28, 2025

View reviewed changes

kommunarr approved these changes May 6, 2025

View reviewed changes

FreeTubeBot merged commit dd23bda into FreeTubeApp:development May 6, 2025
5 checks passed

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 6, 2025

Hide member only videos (Local API) #7208

Hide member only videos (Local API) #7208

Uh oh!

Conversation

PikachuEXE commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Type

Related issue

Description

Screenshots

Testing

Desktop

Additional context

Uh oh!

absidue commented Apr 15, 2025

Uh oh!

PikachuEXE commented Apr 15, 2025

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 15, 2025

Uh oh!

PikachuEXE commented Apr 16, 2025

Uh oh!

PikachuEXE commented Apr 19, 2025

Uh oh!

PikachuEXE commented Apr 19, 2025

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PikachuEXE commented Apr 19, 2025

Uh oh!

absidue commented Apr 19, 2025

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 19, 2025

Uh oh!

PikachuEXE commented Apr 19, 2025

Uh oh!

PikachuEXE commented Apr 20, 2025

Uh oh!

PikachuEXE commented Apr 20, 2025

Uh oh!

PikachuEXE commented Apr 22, 2025

Uh oh!

PikachuEXE commented Apr 25, 2025

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 25, 2025

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PikachuEXE commented Apr 25, 2025

Uh oh!

absidue commented Apr 25, 2025

Uh oh!

PikachuEXE commented Apr 26, 2025

Uh oh!

absidue left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PikachuEXE commented Apr 26, 2025

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 26, 2025

Uh oh!

PikachuEXE commented Apr 15, 2025 •

edited

Loading

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 19, 2025 •

edited

Loading

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 25, 2025 •

edited

Loading

absidue left a comment •

edited

Loading

JamesClarke7283 commented Apr 28, 2025 •

edited

Loading