Detect and identify videos restricted to channel members and add settings to exclude them#5222
Detect and identify videos restricted to channel members and add settings to exclude them#5222syeopite wants to merge 5 commits intoiv-org:masterfrom
Conversation
syeopite
changed the title
|
Thanks! |
| property vr_mode : Bool = true | ||
| property show_nick : Bool = true | ||
| property save_player_pos : Bool = false | ||
| property exclude_members_only_videos : Bool = false |
There was a problem hiding this comment.
Should we exclude the channel only videos by default?
There was a problem hiding this comment.
Honnestly, I don't see a reason to show member-only videos, as Invidious users can't watch them anyway. We always create a dedicated channel page/place for the various "special" playlists (UUMO and co).
| property vr_mode : Bool = true | ||
| property show_nick : Bool = true | ||
| property save_player_pos : Bool = false | ||
| property exclude_members_only_videos : Bool = false |
There was a problem hiding this comment.
Honnestly, I don't see a reason to show member-only videos, as Invidious users can't watch them anyway. We always create a dedicated channel page/place for the various "special" playlists (UUMO and co).
|
|
||
| <div class="pure-g"> | ||
| <% trending.each do |item| %> | ||
| <% next %> |
There was a problem hiding this comment.
I suppose this is a leftover from something else?
| <% if item.badges.members_only? %> | ||
| <span><i class="icon ion ion-md-lock"></i><%=translate(locale, "video_badges_members_only")%></span> | ||
| <% end %> | ||
| <% if item.badges.members_first? %> | ||
| <span><i class="icon ion ion-md-lock"></i><%=translate(locale, "video_badges_members_first")%></span> | ||
| <% end %> |
There was a problem hiding this comment.
What do you think about putting the lock icon before the title?
4 participants
Closes #5213