Skip to content

Fix aggregate PHP routing imports - #3103

Open
ousamabenyounes wants to merge 1 commit into
FriendsOfSymfony:masterfrom
ousamabenyounes:fix/issue-3101
Open

Fix aggregate PHP routing imports#3103
ousamabenyounes wants to merge 1 commit into
FriendsOfSymfony:masterfrom
ousamabenyounes:fix/issue-3101

Conversation

@ousamabenyounes

Copy link
Copy Markdown

Fixes #3101.

Summary

  • load profile, registration, resetting, and change-password routes from the routing configuration directory
  • cover the aggregate PHP routing file through Symfony's bundle-aware routing loader

Test verification (RED → GREEN)

Before the production fix:

FOS\UserBundle\Tests\Routing\RoutingTest::testLoadAllRouting
TypeError: ... ContainerConfigurator, RoutingConfigurator given
ERRORS!
Tests: 33, Assertions: 91, Errors: 1.

After the fix:

OK (33 tests, 94 assertions)

Full local CI replay matched or improved the upstream baseline across PHP 8.2, 8.3, 8.4, 8.5, and Symfony 7.4:

Baseline: OK (145 tests, 407 assertions)
Branch:   OK (146 tests, 413 assertions)
PHP-CS-Fixer: Found 0 of 111 files that can be fixed
Diff coverage: 100% (4 changed lines, 0 missing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Routing : wrong files loading in config/Routing/all.php

1 participant