Skip to content

Fix aggregate PHP routing imports #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ousamabenyounes wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix aggregate PHP routing imports #3103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Resources/config/routing/all.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
return static function (RoutingConfigurator $routes): void {
$routes->import('@FOSUserBundle/Resources/config/routing/security.php');

$routes->import('@FOSUserBundle/Resources/config/profile.php')
$routes->import('@FOSUserBundle/Resources/config/routing/profile.php')
->prefix('/profile');

$routes->import('@FOSUserBundle/Resources/config/registration.php')
$routes->import('@FOSUserBundle/Resources/config/routing/registration.php')
->prefix('/register');

$routes->import('@FOSUserBundle/Resources/config/resetting.php')
$routes->import('@FOSUserBundle/Resources/config/routing/resetting.php')
->prefix('/resetting');

$routes->import('@FOSUserBundle/Resources/config/change_password.php')
$routes->import('@FOSUserBundle/Resources/config/routing/change_password.php')
->prefix('/profile');
};
25 changes: 25 additions & 0 deletions tests/Routing/RoutingTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,37 @@

use PHPUnit\Framework\TestCase;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\HttpKernel\Config\FileLocator as KernelFileLocator;
use Symfony\Component\HttpKernel\KernelInterface;
use Symfony\Component\Routing\Loader\PhpFileLoader;
use Symfony\Component\Routing\Loader\XmlFileLoader;
use Symfony\Component\Routing\RouteCollection;

class RoutingTest extends TestCase
{
private const BUNDLE_PREFIX = '@FOSUserBundle/';
private const SOURCE_DIR = __DIR__.'/../../src';

public function testLoadAllRouting(): void
{
$kernel = $this->createMock(KernelInterface::class);
$kernel->method('locateResource')->willReturnCallback(static function (string $resource): string {
self::assertStringStartsWith(self::BUNDLE_PREFIX, $resource);

return self::SOURCE_DIR.'/'.substr($resource, \strlen(self::BUNDLE_PREFIX));
});

$loader = new PhpFileLoader(new KernelFileLocator($kernel));
$collection = $loader->load(self::SOURCE_DIR.'/Resources/config/routing/all.php');

$expectedRouteNames = array_column(self::loadRoutingProvider(), 0);
$actualRouteNames = array_keys($collection->all());
sort($expectedRouteNames);
sort($actualRouteNames);

self::assertSame($expectedRouteNames, $actualRouteNames);
}

/**
* @dataProvider loadRoutingProvider
*
Expand Down