Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): fix unrestricted route access in UI #10

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

jescalada
Copy link
Collaborator

@jescalada jescalada commented Feb 7, 2025

This PR fixes the route access issue (unlogged users and non-admins can no longer access any route).

The second issue, decoupling the routing and the layout (in other words, removing the common routes from /admin and refactoring them to something else, like /dashboard), will be done in a separate PR as it might be larger than expected.

It builds on top of #7, which should be merged first.

I deliberately omitted the E2E tests as the layout fix will change how routes work.

@jescalada jescalada self-assigned this Feb 7, 2025
@jescalada jescalada linked an issue Feb 7, 2025 that may be closed by this pull request
@jescalada jescalada changed the title Fix unrestricted route access in UI feat(auth): fix unrestricted route access in UI Mar 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@585cda6). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage        ?   61.88%           
=======================================
  Files           ?       49           
  Lines           ?     1805           
  Branches        ?        0           
=======================================
  Hits            ?     1117           
  Misses          ?      688           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up auth access levels for UI
3 participants