-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ts): refactor db
module to use TS and ESM
#27
base: main
Are you sure you want to change the base?
refactor(ts): refactor db
module to use TS and ESM
#27
Conversation
db
module to use TS and ESMdb
module to use TS and ESM
…-refactor-db-module
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage ? 51.70%
=======================================
Files ? 48
Lines ? 1671
Branches ? 53
=======================================
Hits ? 864
Misses ? 790
Partials ? 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-plugin-samples - plugins/git-proxy-plugin-samples/package.json
…ples-manager chore(deps): update dependency @finos/git-proxy to ^1.9.3 - git-proxy-plugin-samples - plugins/git-proxy-plugin-samples/package.json
…es/git-proxy-cli/package.json
fix(deps): update dependency axios to ^1.8.4 - git-proxy-cli - packages/git-proxy-cli/package.json
This PR piggybacks on Fabio's TS config PR (#26) to refactor the entire db module (one of the "helper" modules available). I'm working on #18, but I think it's better to refactor on a module-by-module basis. This will avoid headaches with missing files and converting dependent files from CommonJS to ESM.
The PR also fixes configs to enable TS and ESM to work together and execute mocha tests without breaking.
I verified that nothing breaks by running unit tests and also using a Mongo DB cloud instance to test that the converted Mongo module generates the initial user as expected:
Note: Some types are missing and set to
any
for simplicity. We should fill those in when we add strict TS linting.Changelog
/src/db/mongo
to TS and ESM/src/db/mongo
to TS and ESM