Conversation
Contributor
Author
|
one important note is that we retain almost full test compatibility with current master, and any test changes i made seemed to be essentially unneeded concepts to preserve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to swap out the core async cache logic for lru-cache
lru-cache is a battle-tested library and would be beneficial to incorporate as the basis for our system, as it is hard to reason about the exact nature of async caching
This PR swaps out our logic for lru-cache by making "class AbortablePromiseCache extend LRUCache" (the class from lru-cache's library)
The hope would be to achieve less memory leaks and control memory usage better in jbrowse.
Because we extend the LRUCache class, this does change the API interface. "Wrapping" the class and exposing our own interface could allow us to keep our old interface
Note: I'm only acting on a hunch, not out of a specific memory leak that I observed....